Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2671813004: [wasm] With possible nondeterminism the fuzzer should not check traps (Closed)

Created:
3 years, 10 months ago by ahaas
Modified:
3 years, 10 months ago
Reviewers:
Eric Holk, titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] With possible nondeterminism the fuzzer should not check traps The non-determinism of NaNs does not only affect the result of the test function, it also affects the traps that are thrown. R=titzer@chromium.org, eholk@chromium.org BUG=v8:5924 Review-Url: https://codereview.chromium.org/2671813004 Cr-Commit-Position: refs/heads/master@{#42973} Committed: https://chromium.googlesource.com/v8/v8/+/7517e68202607546cb267a43107ea9cc91af2a34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M test/fuzzer/wasm-code.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 16 (9 generated)
ahaas
3 years, 10 months ago (2017-02-03 11:18:00 UTC) #1
Eric Holk
lgtm
3 years, 10 months ago (2017-02-03 16:32:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671813004/1
3 years, 10 months ago (2017-02-06 08:23:30 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-06 08:23:31 UTC) #10
titzer
On 2017/02/06 08:23:31, commit-bot: I haz the power wrote: > No L-G-T-M from a valid ...
3 years, 10 months ago (2017-02-06 16:49:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671813004/1
3 years, 10 months ago (2017-02-06 16:57:06 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 17:20:00 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7517e68202607546cb267a43107ea9cc91a...

Powered by Google App Engine
This is Rietveld 408576698