Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issue 2671813003: MD Settings: Cros Users: Use display name for non gaia accounts (Closed)

Created:
3 years, 10 months ago by stevenjb
Modified:
3 years, 10 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Cros Users: Use display name for non gaia accounts BUG=680879 Review-Url: https://codereview.chromium.org/2671813003 Cr-Commit-Position: refs/heads/master@{#448134} Committed: https://chromium.googlesource.com/chromium/src/+/66293bc90d0f25974dbd9115e754cab669b35b77

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M chrome/browser/ui/webui/settings/profile_info_handler.cc View 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
stevenjb
3 years, 10 months ago (2017-02-03 02:17:10 UTC) #2
michaelpg
lgtm
3 years, 10 months ago (2017-02-03 21:45:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671813003/1
3 years, 10 months ago (2017-02-03 22:36:03 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-04 00:57:15 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/66293bc90d0f25974dbd9115e754...

Powered by Google App Engine
This is Rietveld 408576698