Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 26718002: Remove references to sconsbuild (Closed)

Created:
7 years, 2 months ago by Nico
Modified:
7 years, 2 months ago
Reviewers:
Lei Zhang, tonyg, dtu
CC:
chromium-reviews, grt+watch_chromium.org, amit, kkania, frankf, chrome-speed-team+watch_google.com, anantha, robertshield, dyu1, dennis_jeffrey, telemetry+watch_chromium.org
Visibility:
Public.

Description

Remove references to sconsbuild. scons hasn't been used in a long time. BUG=305702 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228308

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M build/common.croc View 1 chunk +1 line, -1 line 0 comments Download
M build/landmines.py View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome_paths.py View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/nacl_test_injection/find_chrome.py View 1 chunk +2 lines, -4 lines 2 comments Download
M chrome/test/pyautolib/pyauto_paths.py View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome_frame/chrome_frame.croc View 1 chunk +1 line, -1 line 0 comments Download
M tools/checklicenses/checklicenses.py View 1 chunk +1 line, -1 line 2 comments Download
M tools/telemetry/telemetry/core/backends/chrome/desktop_browser_finder_unittest.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/telemetry/telemetry/core/util.py View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (0 generated)
Nico
https://codereview.chromium.org/26718002/diff/1/chrome/test/nacl_test_injection/find_chrome.py File chrome/test/nacl_test_injection/find_chrome.py (left): https://codereview.chromium.org/26718002/diff/1/chrome/test/nacl_test_injection/find_chrome.py#oldcode29 chrome/test/nacl_test_injection/find_chrome.py:29: # to src/sconsbuild/ rather than src/out/. This is not ...
7 years, 2 months ago (2013-10-09 17:36:40 UTC) #1
Lei Zhang
https://codereview.chromium.org/26718002/diff/1/chrome/test/nacl_test_injection/find_chrome.py File chrome/test/nacl_test_injection/find_chrome.py (left): https://codereview.chromium.org/26718002/diff/1/chrome/test/nacl_test_injection/find_chrome.py#oldcode29 chrome/test/nacl_test_injection/find_chrome.py:29: # to src/sconsbuild/ rather than src/out/. On 2013/10/09 17:36:40, ...
7 years, 2 months ago (2013-10-09 18:59:13 UTC) #2
Nico
https://codereview.chromium.org/26718002/diff/1/tools/checklicenses/checklicenses.py File tools/checklicenses/checklicenses.py (left): https://codereview.chromium.org/26718002/diff/1/tools/checklicenses/checklicenses.py#oldcode496 tools/checklicenses/checklicenses.py:496: if filename.startswith('out/') or filename.startswith('sconsbuild/'): On 2013/10/09 18:59:14, Lei Zhang ...
7 years, 2 months ago (2013-10-09 19:22:25 UTC) #3
Lei Zhang
On 2013/10/09 19:22:25, Nico wrote: > https://codereview.chromium.org/26718002/diff/1/tools/checklicenses/checklicenses.py > File tools/checklicenses/checklicenses.py (left): > > https://codereview.chromium.org/26718002/diff/1/tools/checklicenses/checklicenses.py#oldcode496 > ...
7 years, 2 months ago (2013-10-09 19:27:16 UTC) #4
Lei Zhang
lgtm
7 years, 2 months ago (2013-10-09 19:27:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/26718002/1
7 years, 2 months ago (2013-10-09 19:38:49 UTC) #6
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=29614
7 years, 2 months ago (2013-10-10 00:11:24 UTC) #7
Nico
tbring tongy for telemetry owners
7 years, 2 months ago (2013-10-11 20:50:14 UTC) #8
dtu
telemetry lgtm
7 years, 2 months ago (2013-10-11 20:51:24 UTC) #9
Nico
tbring tonyg for telemetry/OWNERS, next attempt
7 years, 2 months ago (2013-10-11 20:51:30 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/26718002/1
7 years, 2 months ago (2013-10-11 20:51:33 UTC) #11
Nico
Oh, dtu already lg'd, within 1 minute. tonyg, nvm. dtu, thanks!
7 years, 2 months ago (2013-10-11 20:51:54 UTC) #12
commit-bot: I haz the power
List of reviewers changed. tonyg@chromium.org did a drive-by without LGTM'ing!
7 years, 2 months ago (2013-10-12 02:15:34 UTC) #13
tonyg
lgtm
7 years, 2 months ago (2013-10-12 02:19:19 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/26718002/1
7 years, 2 months ago (2013-10-12 02:33:39 UTC) #15
commit-bot: I haz the power
7 years, 2 months ago (2013-10-12 02:38:31 UTC) #16
Message was sent while issue was closed.
Change committed as 228308

Powered by Google App Engine
This is Rietveld 408576698