net/http/http_cache_transaction.cc - Issue 2671793002: Correct handling of ERR_CACHE_LOCK_TIMEOUT for read only transactions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_cache_transaction.cc

Issue 2671793002: Correct handling of ERR_CACHE_LOCK_TIMEOUT for read only transactions. (Closed)

Patch Set: Feedback addressed. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_cache_transaction.cc

diff --git a/net/http/http_cache_transaction.cc b/net/http/http_cache_transaction.cc

index 24002d75215d56bcc5081c22af3d4369806159e8..0e557c05b2f84c232c36291fde0ee00803538927 100644

--- a/net/http/http_cache_transaction.cc

+++ b/net/http/http_cache_transaction.cc

@@ -1160,6 +1160,9 @@ int HttpCache::Transaction::DoAddToEntryComplete(int result) {

}

if (result == ERR_CACHE_LOCK_TIMEOUT) {

+ if (mode_ == READ)

+ return ERR_CACHE_MISS;

// The cache is busy, bypass it for this transaction.

mode_ = NONE;

next_state_ = STATE_SEND_REQUEST;

« no previous file with comments | « net/http/http_cache.cc ('k') | net/http/http_cache_unittest.cc » ('j') | no next file with comments »