net/http/http_cache.cc - Issue 2671793002: Correct handling of ERR_CACHE_LOCK_TIMEOUT for read only transactions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_cache.cc

Issue 2671793002: Correct handling of ERR_CACHE_LOCK_TIMEOUT for read only transactions. (Closed)

Patch Set: Feedback addressed. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/http/http_cache.cc

diff --git a/net/http/http_cache.cc b/net/http/http_cache.cc

index b02ddf02adf0a12669426d13131ce0e33839fe58..72d069c0487089d9796fd837e9f6a7d871c0029e 100644

--- a/net/http/http_cache.cc

+++ b/net/http/http_cache.cc

@@ -230,6 +230,8 @@ void HttpCache::MetadataWriter::Write(const GURL& url,

DCHECK(buf->data());

request_info_.url = url;

request_info_.method = "GET";

+ // todo (crbug.com/690099): Incorrect usage of LOAD_ONLY_FROM_CACHE.

request_info_.load_flags =

LOAD_ONLY_FROM_CACHE | LOAD_SKIP_CACHE_VALIDATION | LOAD_SKIP_VARY_CHECK;

« no previous file with comments | « net/http/http_cache.h ('k') | net/http/http_cache_transaction.cc » ('j') | no next file with comments »