Upstream <link rel=serviceworker> tests.

Upstream <link rel=serviceworker> tests.

BUG=688116
Review-Url: https://codereview.chromium.org/2671783002
Cr-Commit-Position: refs/heads/master@{#448322}
Committed: https://chromium.googlesource.com/chromium/src/+/e46007715a723c2219f49db6199f1af09cbbc7db

[Marijn Kruisselbrink, 2017-02-02 19:46:43]

The CQ bit was checked by mek@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 19:47:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-02-02 20:22:15]

mek@chromium.org changed reviewers:
+ falken@chromium.org

[Marijn Kruisselbrink, 2017-02-02 20:22:16]

I suppose that at some point somebody is going to have to go through all service
worker tests and unify the differences between our copy and the wpt version (and
get rid of our copy)... But I figured I'd start by upstreaming tests for the
features I've worked on, and that don't have any upstream coverage at all yet.

[commit-bot: I haz the power, 2017-02-02 21:22:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 21:22:12]

Dry run: This issue passed the CQ dry run.

[Marijn Kruisselbrink, 2017-02-02 21:29:10]

Description was changed from

==========
Upstream <link rel=serviceworker> tests.

BUG=None
==========

to

==========
Upstream <link rel=serviceworker> tests.

BUG=688116
==========

[falken, 2017-02-03 01:32:21]

lgtm. Thanks for doing this, we've been slowly getting around to it for sw
tests...

Did you check the diff of current external/wpt/.../registration.https.html
against this patch's external/wpt/.../registration-tests.js? That'd be the
useful diff which Rietveld doesn't show here and is a bit hard to read in the
terminal (I don't have a display here).

My comment below is just a memo for historical purposes.

https://codereview.chromium.org/2671783002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/registration-tests.js
(left):

https://codereview.chromium.org/2671783002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/registration-tests.js:281:
}, 'Script URL including uppercase URL-encoded backslash');
Note: This test isn't in the current WPT tests. It was added along with other
small modifications in https://codereview.chromium.org/1260003003 which look
safe.

[Marijn Kruisselbrink, 2017-02-03 18:29:38]

On 2017/02/03 at 01:32:21, falken wrote:
> lgtm. Thanks for doing this, we've been slowly getting around to it for sw
tests...
> 
> Did you check the diff of current external/wpt/.../registration.https.html
against this patch's external/wpt/.../registration-tests.js? That'd be the
useful diff which Rietveld doesn't show here and is a bit hard to read in the
terminal (I don't have a display here).

I thought I did manually, but I somehow missed that the one test wasn't in the
current WPT tests, so I guess I did a bad job. Now from actually running diff:
Changes between existing WPT tests and new WPT tests are roughly:
- change "service_worker_unregister_and_done(t, scope)" to "return
registration.unregister()", since these are promise tests
- replace non-standard assert_promise_rejects with standard promise_rejects
- the two new tests you mentioned (well, the one you mentioned and one other)

No behavioral changes as far as I can tell.

[Marijn Kruisselbrink, 2017-02-03 18:29:41]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2017-02-03 18:30:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Marijn Kruisselbrink, 2017-02-03 22:54:29]

The CQ bit was unchecked by mek@chromium.org

[Marijn Kruisselbrink, 2017-02-03 22:54:31]

The CQ bit was checked by mek@chromium.org

[commit-bot: I haz the power, 2017-02-03 23:02:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[agable, 2017-02-03 23:43:36]

The CQ bit was unchecked by agable@chromium.org

[agable, 2017-02-03 23:43:56]

The CQ bit was checked by agable@chromium.org

[commit-bot: I haz the power, 2017-02-03 23:44:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-04 00:54:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-04 00:54:48]

Failed to apply patch for
third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json:
While running git apply --index -p1;
  error: patch failed:
third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json:3906
  error: third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json: patch does
not apply

Patch:       third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
Index: third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
diff --git a/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
b/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
index
4dd294a15495c4a0f721666d0201b65138c91668..ddb93019c0094076c24e230bd608a3f78fbe571b
100644
--- a/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
+++ b/third_party/WebKit/LayoutTests/external/wpt/MANIFEST.json
@@ -3781,6 +3781,11 @@
      {}
     ]
    ],
+   "./MANIFEST.json": [
+    [
+     {}
+    ]
+   ],
    "./README.md": [
     [
      {}
@@ -3906,11 +3911,6 @@
      {}
     ]
    ],
-   "FileAPI/url/url_createobjecturl_blob-expected.txt": [
-    [
-     {}
-    ]
-   ],
    "FileAPI/url/url_xmlhttprequest_img-ref.html": [
     [
      {}
@@ -15056,6 +15056,11 @@
      {}
     ]
    ],
+   "service-workers/service-worker/resources/registration-tests.js": [
+    [
+     {}
+    ]
+   ],
    "service-workers/service-worker/resources/registration-worker.js": [
     [
      {}
@@ -30145,6 +30150,12 @@
      {}
     ]
    ],
+   "service-workers/service-worker/register-link-element.https.html": [
+    [
+     "/service-workers/service-worker/register-link-element.https.html",
+     {}
+    ]
+   ],
   
"service-workers/service-worker/register-same-scope-different-script-url.https.html":
[
     [
     
"/service-workers/service-worker/register-same-scope-different-script-url.https.html",
@@ -34122,6 +34133,10 @@
    "89af73c41d456ee93bd40921e96414c1908fc48c",
    "support"
   ],
+  "./MANIFEST.json": [
+   "3364d99562a170daf89ad09865f224bc7813fb9e",
+   "support"
+  ],
   "./README.md": [
    "47d52ff4a87b49dec2fb5ceb98211fb1b9af34fb",
    "support"
@@ -34255,7 +34270,7 @@
    "testharness"
   ],
   "FileAPI/idlharness-expected.txt": [
-   "e57737f937070ac349c5a4d9932c487e62018def",
+   "9f32f6f1d0687255b179a4077fcd05c75448801b",
    "support"
   ],
   "FileAPI/idlharness.html": [
@@ -34322,10 +34337,6 @@
    "f7ff9e8b7bb2e09b70935a5d785e0cc5d9d0abf0",
    "support"
   ],
-  "FileAPI/url/url_createobjecturl_blob-expected.txt": [
-   "dc7768766da215a8ed6a95cf30610f1271738134",
-   "support"
-  ],
   "FileAPI/url/url_createobjecturl_blob.html": [
    "bfd9cbe17c74e7b181156c47228beb694d8375af",
    "testharness"
@@ -52086,6 +52097,10 @@
    "864f5435fc40124dbe2c1ffb0e1942fee58228d2",
    "testharness"
   ],
+  "service-workers/service-worker/register-link-element.https.html": [
+   "fcd2a244ad1f12c954c231c479f89beaa3c145e6",
+   "testharness"
+  ],
  
"service-workers/service-worker/register-same-scope-different-script-url.https.html":
[
    "7c32948fe5ff738a38b08ff2d2497ddb63f0a8ef",
    "testharness"
@@ -52119,7 +52134,7 @@
    "testharness"
   ],
   "service-workers/service-worker/registration.https.html": [
-   "9e21fc312a4aae93fcaf6013d20bd38c2cefc9cf",
+   "0a06c368a14c008c385c9df3cde35f090d96d58b",
    "testharness"
   ],
   "service-workers/service-worker/rejections.https.html": [
@@ -52558,6 +52573,10 @@
    "18ee27c8d6a5497bf16b3315ba9eee2b474154b5",
    "support"
   ],
+  "service-workers/service-worker/resources/registration-tests.js": [
+   "5588535a80930c1d526d3b94ec7930a191d729db",
+   "support"
+  ],
   "service-workers/service-worker/resources/registration-worker.js": [
    "048f75fc0d193765d6264e7be132c29e56dd7bcb",
    "support"

[Marijn Kruisselbrink, 2017-02-06 17:34:33]

The CQ bit was checked by mek@chromium.org

[Marijn Kruisselbrink, 2017-02-06 17:34:33]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org
Link to the patchset: https://codereview.chromium.org/2671783002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-06 17:35:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 18:43:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486402473224100,
"parent_rev": "85057c68211954caacdaea3309300e768440a3e1", "commit_rev":
"e46007715a723c2219f49db6199f1af09cbbc7db"}

[commit-bot: I haz the power, 2017-02-06 18:43:44]

Description was changed from

==========
Upstream <link rel=serviceworker> tests.

BUG=688116
==========

to

==========
Upstream <link rel=serviceworker> tests.

BUG=688116

Review-Url: https://codereview.chromium.org/2671783002
Cr-Commit-Position: refs/heads/master@{#448322}
Committed:
https://chromium.googlesource.com/chromium/src/+/e46007715a723c2219f49db6199f...
==========

[commit-bot: I haz the power, 2017-02-06 18:43:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e46007715a723c2219f49db6199f...