Separate state of basic and advanced tab in CBD dialog

chrome/browser/policy/configuration_policy_handler_list_factory.cc

Index: chrome/browser/policy/configuration_policy_handler_list_factory.cc
diff --git a/chrome/browser/policy/configuration_policy_handler_list_factory.cc b/chrome/browser/policy/configuration_policy_handler_list_factory.cc
index 842aabe9d5ca12b2698080a75fc03e5471858585..2dc0049bec62199c0ff95135baf732ff43845643 100644
--- a/chrome/browser/policy/configuration_policy_handler_list_factory.cc
+++ b/chrome/browser/policy/configuration_policy_handler_list_factory.cc
@@ -735,8 +735,9 @@ class BrowsingHistoryPolicyHandler : public TypeCheckingPolicyHandler {
         !deleting_history_allowed) {
       prefs->SetBoolean(
           browsing_data::prefs::kDeleteBrowsingHistory, false);
-      prefs->SetBoolean(
-          browsing_data::prefs::kDeleteDownloadHistory, false);
+      prefs->SetBoolean(browsing_data::prefs::kDeleteBrowsingHistoryBasic,

[emaxx, 2017/02/28 14:16:14]

Looks like there is no actual browser test for AllowDeletingBrowserHistory
policy that covers this logic.

From the discussion above, it seems that the complete end-to-end test (e.g. set
up the policy and check that the UI is disabled and the deletion is not
possible) is quite difficult to write.

But would you mind adding a browser test that covers this logic of mapping the
policy to prefs?
I think the chrome/browser/policy/policy_browsertest.cc file would be a relevant
place for this test. For an example of the test, you could look at
PolicyTest.BookmarkBarEnabled:
https://cs.chromium.org/chromium/src/chrome/browser/policy/policy_browsertest...

[dullweber, 2017/03/02 10:10:00]

I added a test to verify that the prefs are set correctly when activating the
policy.

+                        false);
+      prefs->SetBoolean(browsing_data::prefs::kDeleteDownloadHistory, false);
     }
   }
 };