Separate state of basic and advanced tab in CBD dialog

chrome/browser/policy/configuration_policy_handler_list_factory.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/policy/configuration_policy_handler_list_factory.h"
 
 #include <limits.h>
 #include <stddef.h>
 
 #include <utility>
@@ skipping 717 matching lines @@
   ~BrowsingHistoryPolicyHandler() override {}
 
   void ApplyPolicySettings(const PolicyMap& policies,
                            PrefValueMap* prefs) override {
     const base::Value* value = policies.GetValue(policy_name());
     bool deleting_history_allowed;
     if (value && value->GetAsBoolean(&deleting_history_allowed) &&
         !deleting_history_allowed) {
       prefs->SetBoolean(
           browsing_data::prefs::kDeleteBrowsingHistory, false);
-      prefs->SetBoolean(
-          browsing_data::prefs::kDeleteDownloadHistory, false);
+      prefs->SetBoolean(browsing_data::prefs::kDeleteBrowsingHistoryBasic,

[emaxx, 2017/02/28 14:16:14]

Looks like there is no actual browser test for AllowDeletingBrowserHistory
policy that covers this logic.

From the discussion above, it seems that the complete end-to-end test (e.g. set
up the policy and check that the UI is disabled and the deletion is not
possible) is quite difficult to write.

But would you mind adding a browser test that covers this logic of mapping the
policy to prefs?
I think the chrome/browser/policy/policy_browsertest.cc file would be a relevant
place for this test. For an example of the test, you could look at
PolicyTest.BookmarkBarEnabled:
https://cs.chromium.org/chromium/src/chrome/browser/policy/policy_browsertest...

[dullweber, 2017/03/02 10:10:00]

I added a test to verify that the prefs are set correctly when activating the
policy.

+                        false);
+      prefs->SetBoolean(browsing_data::prefs::kDeleteDownloadHistory, false);
     }
   }
 };
 
 #if BUILDFLAG(ENABLE_EXTENSIONS)
 void GetExtensionAllowedTypesMap(
     std::vector<std::unique_ptr<StringMappingListPolicyHandler::MappingEntry>>*
         result) {
   // Mapping from extension type names to Manifest::Type.
   for (size_t index = 0;
@@ skipping 259 matching lines @@
 #endif  // defined(OS_CHROMEOS)
 
 #if BUILDFLAG(ENABLE_PLUGINS)
   handlers->AddHandler(base::MakeUnique<PluginPolicyHandler>());
 #endif  // BUILDFLAG(ENABLE_PLUGINS)
 
   return handlers;
 }
 
 }  // namespace policy