Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1121)

Issue 2671713005: Avoid calling getName() on declarations that don't have an associated identifier. (Closed)

Created:
3 years, 10 months ago by Łukasz Anforowicz
Modified:
3 years, 10 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Avoid calling getName() on declarations that don't have an associated identifier. BUG=688127 Review-Url: https://codereview.chromium.org/2671713005 Cr-Commit-Position: refs/heads/master@{#447880} Committed: https://chromium.googlesource.com/chromium/src/+/5fa41bde4dca431f3a6843bf20bebf90c2229a08

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 6 chunks +17 lines, -2 lines 1 comment Download

Messages

Total messages: 8 (4 generated)
Łukasz Anforowicz
dcheng@, can you PTAL? https://codereview.chromium.org/2671713005/diff/1/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (left): https://codereview.chromium.org/2671713005/diff/1/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp#oldcode1135 tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:1135: llvm::StringRef old_name = decl->getName(); In ...
3 years, 10 months ago (2017-02-02 22:51:42 UTC) #2
dcheng
lgtm
3 years, 10 months ago (2017-02-02 23:18:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671713005/1
3 years, 10 months ago (2017-02-02 23:25:48 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 23:42:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5fa41bde4dca431f3a6843bf20be...

Powered by Google App Engine
This is Rietveld 408576698