Avoid calling getName() on declarations that don't have an associated identifier.

Avoid calling getName() on declarations that don't have an associated identifier.

BUG=688127
Review-Url: https://codereview.chromium.org/2671713005
Cr-Commit-Position: refs/heads/master@{#447880}
Committed: https://chromium.googlesource.com/chromium/src/+/5fa41bde4dca431f3a6843bf20bebf90c2229a08

[Łukasz Anforowicz, 2017-02-02 22:51:41]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2017-02-02 22:51:42]

dcheng@, can you PTAL?

https://codereview.chromium.org/2671713005/diff/1/tools/clang/rewrite_to_chro...
File tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp (left):

https://codereview.chromium.org/2671713005/diff/1/tools/clang/rewrite_to_chro...
tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp:1135:
llvm::StringRef old_name = decl->getName();
In theory a few GetNameForDecl should also be protected, but they are only
called from DeclRewriterBase::run, so we should be fine as-is.

[dcheng, 2017-02-02 23:18:19]

lgtm

[Łukasz Anforowicz, 2017-02-02 23:24:45]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-02-02 23:25:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 23:41:37]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486077885924130, "parent_rev":
"74921d58b53f2333e9a3c921ecb87ca65721a902", "commit_rev":
"5fa41bde4dca431f3a6843bf20bebf90c2229a08"}

[commit-bot: I haz the power, 2017-02-02 23:42:11]

Description was changed from

==========
Avoid calling getName() on declarations that don't have an associated
identifier.

BUG=688127
==========

to

==========
Avoid calling getName() on declarations that don't have an associated
identifier.

BUG=688127

Review-Url: https://codereview.chromium.org/2671713005
Cr-Commit-Position: refs/heads/master@{#447880}
Committed:
https://chromium.googlesource.com/chromium/src/+/5fa41bde4dca431f3a6843bf20be...
==========

[commit-bot: I haz the power, 2017-02-02 23:42:12]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5fa41bde4dca431f3a6843bf20be...