headless: Add command line flags for logging

headless: Add command line flags for logging

Add support for --enable-logging and --logging-level for headless mode.

BUG=546953
TEST=cr run chrome --headless --enable-logging --v=2

Review-Url: https://codereview.chromium.org/2671713004
Cr-Commit-Position: refs/heads/master@{#447884}
Committed: https://chromium.googlesource.com/chromium/src/+/c417908206d25662cc23a589d0c48a260a77b520

[Sami, 2017-02-02 22:36:39]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[Sami, 2017-02-02 22:36:43]

Description was changed from

==========
headless: Add command line flags for logging

Add support for --enable-logging and --logging-level for headless mode.

BUG=546953
TEST=cr run chrome --headless --enable-logging --v=2
==========

to

==========
headless: Add command line flags for logging

Add support for --enable-logging and --logging-level for headless mode.

BUG=546953
TEST=cr run chrome --headless --enable-logging --v=2
==========

[Sami, 2017-02-02 22:36:43]

skyostil@chromium.org changed reviewers:
+ eseckler@chromium.org

[Sami, 2017-02-02 22:37:33]

skyostil@chromium.org changed reviewers:
+ altimin@chromium.org

[commit-bot: I haz the power, 2017-02-02 22:37:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sami, 2017-02-02 22:37:40]

PTAL.

[altimin, 2017-02-02 22:44:46]

https://codereview.chromium.org/2671713004/diff/1/headless/app/headless_shell.cc
File headless/app/headless_shell.cc (right):

https://codereview.chromium.org/2671713004/diff/1/headless/app/headless_shell...
headless/app/headless_shell.cc:464: const base::FilePath
log_filename(FILE_PATH_LITERAL("chrome_debug.log"));
Let's make output file configurable. We can use value of kEnableLogging switch.

[Eric Seckler, 2017-02-02 22:50:12]

looks good, but might need to happen in HeadlessContentMainDelegate so it
affects renderers too? :)

https://codereview.chromium.org/2671713004/diff/1/headless/app/headless_shell...
File headless/app/headless_shell_switches.h (right):

https://codereview.chromium.org/2671713004/diff/1/headless/app/headless_shell...
headless/app/headless_shell_switches.h:25: // Switches which are replicated from
content.
while you're at it, shall we move kRemoteDebuggingPort and kHostResolverRules)
over here as well, and then get rid of content_switches.h include in
headless_shell.cc? :)

[commit-bot: I haz the power, 2017-02-02 23:08:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 23:08:24]

Dry run: This issue passed the CQ dry run.

[Sami, 2017-02-02 23:15:33]

https://codereview.chromium.org/2671713004/diff/1/headless/app/headless_shell.cc
File headless/app/headless_shell.cc (right):

https://codereview.chromium.org/2671713004/diff/1/headless/app/headless_shell...
headless/app/headless_shell.cc:464: const base::FilePath
log_filename(FILE_PATH_LITERAL("chrome_debug.log"));
On 2017/02/02 22:44:45, altimin wrote:
> Let's make output file configurable. We can use value of kEnableLogging
switch.

Done.

https://codereview.chromium.org/2671713004/diff/1/headless/app/headless_shell...
File headless/app/headless_shell_switches.h (right):

https://codereview.chromium.org/2671713004/diff/1/headless/app/headless_shell...
headless/app/headless_shell_switches.h:25: // Switches which are replicated from
content.
On 2017/02/02 22:50:12, Eric Seckler wrote:
> while you're at it, shall we move kRemoteDebuggingPort and kHostResolverRules)
> over here as well, and then get rid of content_switches.h include in
> headless_shell.cc? :)

Done.

[Sami, 2017-02-02 23:16:22]

The CQ bit was checked by skyostil@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 23:17:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[altimin, 2017-02-02 23:18:10]

lgtm

[Sami, 2017-02-02 23:34:44]

The CQ bit was unchecked by skyostil@chromium.org

[Sami, 2017-02-02 23:34:49]

The CQ bit was checked by skyostil@chromium.org

[commit-bot: I haz the power, 2017-02-02 23:35:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 23:46:58]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486078489027020,
"parent_rev": "084fdb4fa1dad8cddc9d09601a8c8c0e2e7b3e4f", "commit_rev":
"c417908206d25662cc23a589d0c48a260a77b520"}

[commit-bot: I haz the power, 2017-02-02 23:47:32]

Description was changed from

==========
headless: Add command line flags for logging

Add support for --enable-logging and --logging-level for headless mode.

BUG=546953
TEST=cr run chrome --headless --enable-logging --v=2
==========

to

==========
headless: Add command line flags for logging

Add support for --enable-logging and --logging-level for headless mode.

BUG=546953
TEST=cr run chrome --headless --enable-logging --v=2

Review-Url: https://codereview.chromium.org/2671713004
Cr-Commit-Position: refs/heads/master@{#447884}
Committed:
https://chromium.googlesource.com/chromium/src/+/c417908206d25662cc23a589d0c4...
==========

[commit-bot: I haz the power, 2017-02-02 23:47:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c417908206d25662cc23a589d0c4...

[Eric Seckler, 2017-02-02 23:56:10]

https://codereview.chromium.org/2671713004/diff/20001/headless/app/headless_s...
File headless/app/headless_shell_switches.h (right):

https://codereview.chromium.org/2671713004/diff/20001/headless/app/headless_s...
headless/app/headless_shell_switches.h:26: using ::switches::kEnableLogging;
do we still need the logging switches here now?

[Eric Seckler, 2017-02-02 23:57:19]

https://codereview.chromium.org/2671713004/diff/20001/headless/lib/headless_c...
File headless/lib/headless_content_main_delegate.cc (right):

https://codereview.chromium.org/2671713004/diff/20001/headless/lib/headless_c...
headless/lib/headless_content_main_delegate.cc:119: settings.delete_old =
logging::DELETE_OLD_LOG_FILE;
I think, in renderer processes, this shouldn't be DELETE, but append.