Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2671713003: Gtk3: Fix border colors on Gtk3.20 (Closed)

Created:
3 years, 10 months ago by Tom (Use chromium acct)
Modified:
3 years, 10 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: Fix border colors on Gtk3.20 This CL fixes a bug where borders would always render 1px x 1px instead of the widget width and height. In addition, it also adds color_utils::GetReadableColor in LoadGtkValues, and uses GtkButton borders instead of GtkEntry borders in headerbars, since they're more common. BUG=132847 R=erg@chromium.org Review-Url: https://codereview.chromium.org/2671713003 Cr-Commit-Position: refs/heads/master@{#448066} Committed: https://chromium.googlesource.com/chromium/src/+/a27376a8ce139b126d86a9d587e05e82298dbed4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M chrome/browser/ui/libgtkui/gtk_ui.cc View 3 chunks +24 lines, -20 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
Tom (Use chromium acct)
erg@ PTAL This adds a line that accidentally got reverted from another CL. In addition, ...
3 years, 10 months ago (2017-02-02 20:00:09 UTC) #2
Elliot Glaysher
lgtm
3 years, 10 months ago (2017-02-03 16:03:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671713003/1
3 years, 10 months ago (2017-02-03 18:16:17 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 20:48:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a27376a8ce139b126d86a9d587e0...

Powered by Google App Engine
This is Rietveld 408576698