[Telemetry] Validate args in js_template rendering

[Telemetry] Validate args in js_template rendering

Check that all arguments passed to the template rendering are actually
used, thus helping to catch misspellings. A TypeError is raised for any
unexpected arguments not used in the template.

Additionally, the `timeout` and `context_id` arguments on JS evaluate
APIs are no longer passed down to template rendering. Trying to use
these keywords in the template will now raise a KeyError.

BUG=catapult:#3028

Review-Url: https://codereview.chromium.org/2671693002
Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a28b8398067e93f8f49fe422436459c13b6d7a34

[perezju, 2017-02-02 11:09:23]

The CQ bit was checked by perezju@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 11:09:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[perezju, 2017-02-02 11:11:28]

perezju@chromium.org changed reviewers:
+ nednguyen@google.com

[perezju, 2017-02-02 11:21:12]

The CQ bit was checked by perezju@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 11:21:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 11:41:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 11:41:39]

Dry run: This issue passed the CQ dry run.

[nednguyen, 2017-02-02 14:33:50]

https://codereview.chromium.org/2671693002/diff/20001/telemetry/telemetry/uti...
File telemetry/telemetry/util/js_template.py (right):

https://codereview.chromium.org/2671693002/diff/20001/telemetry/telemetry/uti...
telemetry/telemetry/util/js_template.py:61: ', '.join(repr(str(k)) for k in
sorted(unused))))
On another hand, ca  we also output error if there are template variables
without matching argument?

[perezju, 2017-02-02 14:42:44]

https://codereview.chromium.org/2671693002/diff/20001/telemetry/telemetry/uti...
File telemetry/telemetry/util/js_template.py (right):

https://codereview.chromium.org/2671693002/diff/20001/telemetry/telemetry/uti...
telemetry/telemetry/util/js_template.py:61: ', '.join(repr(str(k)) for k in
sorted(unused))))
On 2017/02/02 14:33:50, nednguyen wrote:
> On another hand, ca  we also output error if there are template variables
> without matching argument?

Those will raise a KeyError when trying to read the arg in line 49. See
testRenderRaisesWithUnknownIdentifier.

[nednguyen, 2017-02-02 14:45:13]

On 2017/02/02 14:42:44, perezju wrote:
>
https://codereview.chromium.org/2671693002/diff/20001/telemetry/telemetry/uti...
> File telemetry/telemetry/util/js_template.py (right):
> 
>
https://codereview.chromium.org/2671693002/diff/20001/telemetry/telemetry/uti...
> telemetry/telemetry/util/js_template.py:61: ', '.join(repr(str(k)) for k in
> sorted(unused))))
> On 2017/02/02 14:33:50, nednguyen wrote:
> > On another hand, ca  we also output error if there are template variables
> > without matching argument?
> 
> Those will raise a KeyError when trying to read the arg in line 49. See
> testRenderRaisesWithUnknownIdentifier.

lgtm

[perezju, 2017-02-02 14:46:43]

The CQ bit was checked by perezju@chromium.org

[commit-bot: I haz the power, 2017-02-02 14:46:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 14:48:28]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486046803045390,
"parent_rev": "638356c49e2109a6292ba906402b566cc19996d6", "commit_rev":
"a28b8398067e93f8f49fe422436459c13b6d7a34"}

[commit-bot: I haz the power, 2017-02-02 14:48:31]

Description was changed from

==========
[Telemetry] Validate args in js_template rendering

Check that all arguments passed to the template rendering are actually
used, thus helping to catch misspellings. A TypeError is raised for any
unexpected arguments not used in the template.

Additionally, the `timeout` and `context_id` arguments on JS evaluate
APIs are no longer passed down to template rendering. Trying to use
these keywords in the template will now raise a KeyError.

BUG=catapult:#3028
==========

to

==========
[Telemetry] Validate args in js_template rendering

Check that all arguments passed to the template rendering are actually
used, thus helping to catch misspellings. A TypeError is raised for any
unexpected arguments not used in the template.

Additionally, the `timeout` and `context_id` arguments on JS evaluate
APIs are no longer passed down to template rendering. Trying to use
these keywords in the template will now raise a KeyError.

BUG=catapult:#3028

Review-Url: https://codereview.chromium.org/2671693002
Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2017-02-02 14:48:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...