Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2671673003: Revert of [string] Migrate String.prototype.{split,replace} to TF (Closed)

Created:
3 years, 10 months ago by Michael Achenbach
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [string] Migrate String.prototype.{split,replace} to TF (patchset #12 id:220001 of https://codereview.chromium.org/2663803002/ ) Reason for revert: Breaks win64 debug: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20debug/builds/14967 Original issue's description: > [string] Migrate String.prototype.{split,replace} to TF > > BUG= > > Review-Url: https://codereview.chromium.org/2663803002 > Cr-Commit-Position: refs/heads/master@{#42881} > Committed: https://chromium.googlesource.com/v8/v8/+/65ad1e35d9a97c1126a55cc9d3014598fd224259 TBR=bmeurer@chromium.org,ishell@chromium.org,yangguo@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2671673003 Cr-Commit-Position: refs/heads/master@{#42882} Committed: https://chromium.googlesource.com/v8/v8/+/2517b79cd6a482450cde8928022b08ba36266e26

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -524 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 2 chunks +1 line, -5 lines 0 comments Download
M src/builtins/builtins.h View 1 chunk +0 lines, -4 lines 0 comments Download
D src/builtins/builtins-regexp.h View 1 chunk +0 lines, -94 lines 0 comments Download
M src/builtins/builtins-regexp.cc View 2 chunks +75 lines, -3 lines 0 comments Download
M src/builtins/builtins-string.cc View 3 chunks +0 lines, -360 lines 0 comments Download
M src/js/string.js View 5 chunks +205 lines, -0 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime/runtime-strings.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M src/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/debugger/debug/debug-evaluate-no-side-effect-builtins.js View 1 chunk +1 line, -4 lines 0 comments Download
M test/mjsunit/string-replace.js View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Michael Achenbach
Created Revert of [string] Migrate String.prototype.{split,replace} to TF
3 years, 10 months ago (2017-02-02 11:10:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671673003/1
3 years, 10 months ago (2017-02-02 11:10:20 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 11:10:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2517b79cd6a482450cde8928022b08ba362...

Powered by Google App Engine
This is Rietveld 408576698