Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 2671653004: Move impl of identity.GetAccounts() extension API to its own file (Closed)

Created:
3 years, 10 months ago by blundell
Modified:
3 years, 10 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move impl of identity.GetAccounts() extension API to its own file As a precursor to a refactoring of the identity extension API implementation to use the Identity Service, I am moving the implementations of the six identity extension API functions to their own files, rather than all being lumped together in identity_api.*. This will make it easier to analyze each of these function implementations independently and incrementally convert them to use the Identity Service. BUG=685654 Review-Url: https://codereview.chromium.org/2671653004 Cr-Commit-Position: refs/heads/master@{#447998} Committed: https://chromium.googlesource.com/chromium/src/+/e1b2a78c415b404e5dc975c34d5e0b4dee94ba1f

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -42 lines) Patch
M chrome/browser/extensions/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.h View 2 chunks +1 line, -14 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/extensions/api/identity/identity_get_accounts_function.h View 1 chunk +29 lines, -0 lines 0 comments Download
A chrome/browser/extensions/api/identity/identity_get_accounts_function.cc View 1 1 chunk +43 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (8 generated)
blundell
3 years, 10 months ago (2017-02-02 13:33:36 UTC) #6
Ken Rockot(use gerrit already)
lgtm
3 years, 10 months ago (2017-02-02 15:18:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671653004/20001
3 years, 10 months ago (2017-02-03 13:38:04 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 15:00:41 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e1b2a78c415b404e5dc975c34d5e...

Powered by Google App Engine
This is Rietveld 408576698