Rename WebApplicationCacheHostImpl::IsNewMasterEntry enum to not use YES/NO.

Rename WebApplicationCacheHostImpl::IsNewMasterEntry enum to not use YES/NO.

Avoid clashes with YES/NO keywords in Objective-C.

BUG=687822
Review-Url: https://codereview.chromium.org/2671643002
Cr-Commit-Position: refs/heads/master@{#447955}
Committed: https://chromium.googlesource.com/chromium/src/+/edc842d64c63e7d820589a19d778a7af6355d64c

[Patti Lor, 2017-02-02 03:41:58]

The CQ bit was checked by patricialor@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 03:42:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 06:05:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 06:05:56]

Dry run: This issue passed the CQ dry run.

[Patti Lor, 2017-02-03 00:07:27]

patricialor@chromium.org changed reviewers:
+ michaeln@chromium.org

[Patti Lor, 2017-02-03 00:07:27]

Hi michaeln@, PTAL - just a couple renames. Thanks!

[michaeln, 2017-02-03 00:43:55]

https://codereview.chromium.org/2671643002/diff/1/content/child/appcache/web_...
File content/child/appcache/web_application_cache_host_impl.cc (right):

https://codereview.chromium.org/2671643002/diff/1/content/child/appcache/web_...
content/child/appcache/web_application_cache_host_impl.cc:204:
is_new_master_entry_ = OLD_ENTRY;
would MAYBE, YUP, NOPE be more readable?

lgtm

[Patti Lor, 2017-02-03 01:08:15]

Thanks for your review!

https://codereview.chromium.org/2671643002/diff/1/content/child/appcache/web_...
File content/child/appcache/web_application_cache_host_impl.cc (right):

https://codereview.chromium.org/2671643002/diff/1/content/child/appcache/web_...
content/child/appcache/web_application_cache_host_impl.cc:204:
is_new_master_entry_ = OLD_ENTRY;
On 2017/02/03 00:43:55, michaeln wrote:
> would MAYBE, YUP, NOPE be more readable?
> 
> lgtm

Yeah, I was also a bit worried about losing a bit of readability. I think with
NEW_ENTRY/OLD_ENTRY though we can avoid future devs reading the code and
wondering why "YUP/NOPE" were used instead of "YES/NO" and trying to change it.

[Patti Lor, 2017-02-03 01:08:20]

The CQ bit was checked by patricialor@chromium.org

[commit-bot: I haz the power, 2017-02-03 01:08:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-03 07:06:40]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486084100049180, "parent_rev":
"8f2d158964de19b39244ecf483be0b156cb38224", "commit_rev":
"edc842d64c63e7d820589a19d778a7af6355d64c"}

[commit-bot: I haz the power, 2017-02-03 07:07:10]

Description was changed from

==========
Rename WebApplicationCacheHostImpl::IsNewMasterEntry enum to not use YES/NO.

Avoid clashes with YES/NO keywords in Objective-C.

BUG=687822
==========

to

==========
Rename WebApplicationCacheHostImpl::IsNewMasterEntry enum to not use YES/NO.

Avoid clashes with YES/NO keywords in Objective-C.

BUG=687822

Review-Url: https://codereview.chromium.org/2671643002
Cr-Commit-Position: refs/heads/master@{#447955}
Committed:
https://chromium.googlesource.com/chromium/src/+/edc842d64c63e7d820589a19d778...
==========

[commit-bot: I haz the power, 2017-02-03 07:07:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/edc842d64c63e7d820589a19d778...