Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2671623003: DevTools: rebaseline tracing tests (Closed)

Created:
3 years, 10 months ago by chenwilliam
Modified:
3 years, 10 months ago
Reviewers:
caseq, alph, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: rebaseline tracing tests BUG=682078 Review-Url: https://codereview.chromium.org/2671623003 Cr-Commit-Position: refs/heads/master@{#448722} Committed: https://chromium.googlesource.com/chromium/src/+/ce6be73c58c3275a42ed81ba5935d336390ab680

Patch Set 1 #

Patch Set 2 : update testexpect #

Patch Set 3 : make everyone an owner within /tests/ #

Patch Set 4 : rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -43 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/tests/OWNERS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/devtools/tests/TestExpectations View 1 2 3 2 chunks +10 lines, -1 line 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/http/tests/inspector/tracing/timeline-receive-response-event-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector-protocol/timeline/fetch-as-stream-expected.txt View 1 chunk +8 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/tracing/timeline-js/timeline-js-line-level-profile-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/tracing/timeline-js/timeline-script-tag-1-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/tracing/timeline-js/timeline-script-tag-2-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/tracing/timeline-network/timeline-network-resource-expected.txt View 2 chunks +1 line, -5 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/tracing/timeline-time/timeline-time-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/devtools/tests/baseline/protocol-1.2/inspector/tracing/timeline-time/timeline-timer-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 20 (11 generated)
chenwilliam
ptal
3 years, 10 months ago (2017-02-02 03:05:19 UTC) #4
chenwilliam
ping :) - let me know if you have any questions about these tests. The ...
3 years, 10 months ago (2017-02-03 20:00:50 UTC) #5
alph
lgtm
3 years, 10 months ago (2017-02-06 19:05:07 UTC) #6
chenwilliam
pfeldman@ ptal
3 years, 10 months ago (2017-02-06 19:09:43 UTC) #8
pfeldman
lgtm
3 years, 10 months ago (2017-02-07 01:49:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671623003/40001
3 years, 10 months ago (2017-02-07 02:08:28 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/148465) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 10 months ago (2017-02-07 02:10:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671623003/60001
3 years, 10 months ago (2017-02-07 19:11:39 UTC) #17
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 20:37:54 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ce6be73c58c3275a42ed81ba5935...

Powered by Google App Engine
This is Rietveld 408576698