Expose WindowAndroid from WebContents.

Expose WindowAndroid from WebContents.

Currently, this requires making a hop between
ContentViewCore#fromWebContents#getWindowAndroid.

BUG=

Review-Url: https://codereview.chromium.org/2671623002
Cr-Commit-Position: refs/heads/master@{#454727}
Committed: https://chromium.googlesource.com/chromium/src/+/d6c15bfcf01549bf92de247886214b872758b387

[Ted C, 2017-02-02 01:05:42]

tedchoc@chromium.org changed reviewers:
+ boliu@chromium.org

[Ted C, 2017-02-02 01:05:43]

PTAL

[boliu, 2017-02-02 03:34:01]

is there a first use case?

https://codereview.chromium.org/2671623002/diff/1/content/browser/web_content...
File content/browser/web_contents/web_contents_android.cc (right):

https://codereview.chromium.org/2671623002/diff/1/content/browser/web_content...
content/browser/web_contents/web_contents_android.cc:285: return
ScopedJavaLocalRef<jobject>();
nullptr should work

https://codereview.chromium.org/2671623002/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
(right):

https://codereview.chromium.org/2671623002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content_public/browser/WebContents.java:41:
* @return The top level WindowAndroid associated with this WebContents.
add a note that this might be null?

[Ted C, 2017-03-03 20:55:26]

Got back to this, updated all the easy callers I could spot as well.

https://codereview.chromium.org/2671623002/diff/1/content/browser/web_content...
File content/browser/web_contents/web_contents_android.cc (right):

https://codereview.chromium.org/2671623002/diff/1/content/browser/web_content...
content/browser/web_contents/web_contents_android.cc:285: return
ScopedJavaLocalRef<jobject>();
On 2017/02/02 03:34:00, boliu wrote:
> nullptr should work

Done.

https://codereview.chromium.org/2671623002/diff/1/content/public/android/java...
File
content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
(right):

https://codereview.chromium.org/2671623002/diff/1/content/public/android/java...
content/public/android/java/src/org/chromium/content_public/browser/WebContents.java:41:
* @return The top level WindowAndroid associated with this WebContents.
On 2017/02/02 03:34:00, boliu wrote:
> add a note that this might be null?

Done.

[boliu, 2017-03-03 21:06:40]

lgtm

[Ted C, 2017-03-04 00:12:38]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2017-03-04 00:12:38]

The patchset sent to the CQ was uploaded after l-g-t-m from boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2671623002/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-04 00:13:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-04 00:50:16]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488586358156740,
"parent_rev": "942a2f8509d28f5aee39b29378a199fa765bd2de", "commit_rev":
"d6c15bfcf01549bf92de247886214b872758b387"}

[commit-bot: I haz the power, 2017-03-04 00:50:52]

Description was changed from

==========
Expose WindowAndroid from WebContents.

Currently, this requires making a hop between
ContentViewCore#fromWebContents#getWindowAndroid.

BUG=
==========

to

==========
Expose WindowAndroid from WebContents.

Currently, this requires making a hop between
ContentViewCore#fromWebContents#getWindowAndroid.

BUG=

Review-Url: https://codereview.chromium.org/2671623002
Cr-Commit-Position: refs/heads/master@{#454727}
Committed:
https://chromium.googlesource.com/chromium/src/+/d6c15bfcf01549bf92de24788621...
==========

[commit-bot: I haz the power, 2017-03-04 00:50:53]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d6c15bfcf01549bf92de24788621...