Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 2671613006: Made testCachingBehaviorOnOpenNewTab more robust. (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
baxley
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made testCachingBehaviorOnOpenNewTab more robust. Wait until new Tab is open after opening it using DOM. |waitForPageToFinishLoading| does not wait for the new Tab. BUG=None Review-Url: https://codereview.chromium.org/2671613006 Cr-Commit-Position: refs/heads/master@{#448041} Committed: https://chromium.googlesource.com/chromium/src/+/7da96c48c351c6fd61c73a28ca94e15680dc24d1

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Reverted unneeded changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ios/chrome/browser/web/cache_egtest.mm View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Eugene But (OOO till 7-30)
3 years, 10 months ago (2017-02-03 01:37:25 UTC) #2
baxley
lgtm
3 years, 10 months ago (2017-02-03 15:24:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671613006/40001
3 years, 10 months ago (2017-02-03 19:05:24 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 19:25:05 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7da96c48c351c6fd61c73a28ca94...

Powered by Google App Engine
This is Rietveld 408576698