Fix a couple of TODOs

Fix a couple of notification TODOs

Delete obsolete notifiations from the database
Stop silently ignoring notifications without an ID

BUG=596161
Review-Url: https://codereview.chromium.org/2671603005
Cr-Commit-Position: refs/heads/master@{#448721}
Committed: https://chromium.googlesource.com/chromium/src/+/e50bfa204461eba626ab5891799669f9bf8231be

[Miguel Garcia, 2017-02-03 17:36:24]

The CQ bit was checked by miguelg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-03 17:36:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Miguel Garcia, 2017-02-03 18:25:25]

Description was changed from

==========
Fix a couple of TODOs

Delete obsolete notifiations from the database
Stop silently ignoring notifications without an ID

BUG=596161
==========

to

==========
Fix a couple of notification TODOs

Delete obsolete notifiations from the database
Stop silently ignoring notifications without an ID

BUG=596161
==========

[Miguel Garcia, 2017-02-03 18:25:56]

miguelg@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2017-02-03 18:57:56]

https://codereview.chromium.org/2671603005/diff/1/content/browser/notificatio...
File content/browser/notifications/platform_notification_context_impl.cc
(right):

https://codereview.chromium.org/2671603005/diff/1/content/browser/notificatio...
content/browser/notifications/platform_notification_context_impl.cc:279:
database_->DeleteNotificationData(it, origin);
This won't actually work (and would need a test) -- reading all notifications
displayed through the NotificationDisplayService will return *all* of them,
regardless of type and origin. In effect, all notifications shown for other
origins would be added to |obsolete_notifications|, but this call would be a
no-op as none of them are associated with |origin|...

[Peter Beverloo, 2017-02-07 17:04:38]

Yes it does. lgtm

[Miguel Garcia, 2017-02-07 17:35:56]

The CQ bit was checked by miguelg@chromium.org

[commit-bot: I haz the power, 2017-02-07 17:36:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 20:34:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486488956468140, "parent_rev":
"87434c433441746588f5ee22822fdc422a04e225", "commit_rev":
"e50bfa204461eba626ab5891799669f9bf8231be"}

[commit-bot: I haz the power, 2017-02-07 20:35:03]

Description was changed from

==========
Fix a couple of notification TODOs

Delete obsolete notifiations from the database
Stop silently ignoring notifications without an ID

BUG=596161
==========

to

==========
Fix a couple of notification TODOs

Delete obsolete notifiations from the database
Stop silently ignoring notifications without an ID

BUG=596161

Review-Url: https://codereview.chromium.org/2671603005
Cr-Commit-Position: refs/heads/master@{#448721}
Committed:
https://chromium.googlesource.com/chromium/src/+/e50bfa204461eba626ab58917996...
==========

[commit-bot: I haz the power, 2017-02-07 20:35:04]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e50bfa204461eba626ab58917996...