Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2671603004: Remove a major source of flaky service test failures. (Closed)

Created:
3 years, 10 months ago by turnidge
Modified:
3 years, 10 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove a major source of flaky service test failures. The first three bugs below have bug reports which indicate that they will be fixed. The bottom three bugs were filed without log information, so it is impossible to know if they will be fixed or not, but it is quite possible. Closes #26470 Closes #28947 Closes #28605 Closes #28091 Closes #28184 Closes #28185 BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/e60003d1a72c0fccf81357c6f522c637946d202f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M runtime/observatory/tests/service/service.status View 1 chunk +0 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
turnidge
3 years, 10 months ago (2017-02-02 22:48:51 UTC) #2
Cutch
lgtm
3 years, 10 months ago (2017-02-02 22:49:19 UTC) #3
turnidge
3 years, 10 months ago (2017-02-02 22:54:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e60003d1a72c0fccf81357c6f522c637946d202f.

Powered by Google App Engine
This is Rietveld 408576698