Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: runtime/observatory/tests/service/test_helper.dart

Issue 2671603004: Remove a major source of flaky service test failures. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/service.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/test_helper.dart
diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart
index eeb6805e12a1885a4418f11ddc8bc8afde99ef17..58162431f0d13324955ed65fed1273f799f9e5c1 100644
--- a/runtime/observatory/tests/service/test_helper.dart
+++ b/runtime/observatory/tests/service/test_helper.dart
@@ -281,6 +281,7 @@ class _ServiceTesterRunner {
bool testeeControlsServer: false,
bool useAuthToken: false}) {
var process = new _ServiceTesteeLauncher();
+ bool testsDone = false;
process.launch(pause_on_start, pause_on_exit,
pause_on_unhandled_exceptions,
testeeControlsServer,
@@ -325,11 +326,18 @@ class _ServiceTesterRunner {
}
}
+ print('All service tests completed successfully.');
+ testsDone = true;
await process.requestExit();
}, onError: (error, stackTrace) {
- process.requestExit();
- print('Unexpected exception in service tests: $error\n$stackTrace');
- throw error;
+ if (testsDone) {
+ print('Ignoring late exception during process exit:\n'
+ '$error\n#stackTrace');
+ } else {
+ process.requestExit();
+ print('Unexpected exception in service tests: $error\n$stackTrace');
+ throw error;
+ }
});
});
}
« no previous file with comments | « runtime/observatory/tests/service/service.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698