Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2671583003: DevTools: move custom formatter setting to SDK (Closed)

Created:
3 years, 10 months ago by chenwilliam
Modified:
3 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: move custom formatter setting to SDK Because it's referenced in runtime, the setting should be defined in SDK to be consistent with other settings. BUG=687641 Review-Url: https://codereview.chromium.org/2671583003 Cr-Commit-Position: refs/heads/master@{#447714} Committed: https://chromium.googlesource.com/chromium/src/+/48f5fd7ac00d78dc76c72915135bd63c12ed23b9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M third_party/WebKit/Source/devtools/front_end/components/module.json View 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/module.json View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
chenwilliam
ptal
3 years, 10 months ago (2017-02-02 01:22:50 UTC) #3
pfeldman
lgtm
3 years, 10 months ago (2017-02-02 01:24:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671583003/1
3 years, 10 months ago (2017-02-02 01:40:03 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
3 years, 10 months ago (2017-02-02 05:35:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671583003/1
3 years, 10 months ago (2017-02-02 05:41:38 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-02 07:18:50 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/48f5fd7ac00d78dc76c72915135b...

Powered by Google App Engine
This is Rietveld 408576698