Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2671553004: Create platform/bindings (Closed)

Created:
3 years, 10 months ago by adithyas
Modified:
3 years, 8 months ago
Reviewers:
haraken, jbroman
CC:
abarth-chromium, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, dglazkov+blink, dominicc+watchlist_chromium.org, eae+blinkwatch, eric.carlson_apple.com, falken+watch_chromium.org, feature-media-reviews_chromium.org, fs, gasubic, horo+watch_chromium.org, kinuko+worker_chromium.org, kinuko+watch, loading-reviews+parser_chromium.org, mlamouri+watch-blink_chromium.org, rwlbuis, shimazu+worker_chromium.org, sof, nessy, Srirama, webcomponents-bugzilla_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Create platform/bindings - Add OWNERS file - Move Microtask.h/cpp (but keep bindings/core/v8/Microtask.h) BUG=682322 Review-Url: https://codereview.chromium.org/2671553004 Cr-Commit-Position: refs/heads/master@{#467030} Committed: https://chromium.googlesource.com/chromium/src/+/aeb180b1bc8066c2095c124d55e744be0124f020

Patch Set 1 #

Patch Set 2 : Remove DEPS #

Patch Set 3 : Revert changes to core/BUILD.gn, fix copyrights #

Patch Set 4 : Update #

Patch Set 5 : Rebase + Update OWNERS #

Patch Set 6 : Add TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -108 lines) Patch
M third_party/WebKit/Source/bindings/bindings.gni View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/Microtask.h View 1 2 3 4 5 1 chunk +3 lines, -48 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/Microtask.cpp View 1 2 3 1 chunk +0 lines, -56 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/platform/bindings/Microtask.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/platform/bindings/Microtask.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/Source/platform/bindings/OWNERS View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 22 (17 generated)
adithyas
3 years, 8 months ago (2017-04-24 21:00:45 UTC) #14
jbroman
+haraken lgtm, but I'd like Kentaro to +1 as well before landing :)
3 years, 8 months ago (2017-04-24 21:06:04 UTC) #16
haraken
LGTM
3 years, 8 months ago (2017-04-25 13:45:51 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671553004/100001
3 years, 8 months ago (2017-04-25 14:44:05 UTC) #19
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 17:19:02 UTC) #22
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/aeb180b1bc8066c2095c124d55e7...

Powered by Google App Engine
This is Rietveld 408576698