Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2671543002: [layoutng] Also add a DCHECK for the percentage resolution size (Closed)

Created:
3 years, 10 months ago by cbiesinger
Modified:
3 years, 10 months ago
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, dgrogan+ng_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[layoutng] Also add a DCHECK for the percentage resolution size R=atotic@chromium.org,glebl@chromium.org BUG=635619 Review-Url: https://codereview.chromium.org/2671543002 Cr-Commit-Position: refs/heads/master@{#447627} Committed: https://chromium.googlesource.com/chromium/src/+/d1b7237e603d1993bdeb0eefed98002d433ba31f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_length_utils.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
cbiesinger
3 years, 10 months ago (2017-02-01 20:15:19 UTC) #1
Gleb Lanbin
3 years, 10 months ago (2017-02-01 20:28:36 UTC) #4
Gleb Lanbin
lgtm
3 years, 10 months ago (2017-02-01 21:38:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671543002/1
3 years, 10 months ago (2017-02-01 21:40:59 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-01 22:50:49 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d1b7237e603d1993bdeb0eefed98...

Powered by Google App Engine
This is Rietveld 408576698