MD Settings: Fix some tests that break when run in Vulcanized mode.

MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is present during
testing, since all browserPreload URLs are forwarded to the top level document.
Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and therefore
a way to reset their value is introduced, by adding PolymerTest.clearBody() and
detached() calls as necessary.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2671493002
Cr-Commit-Position: refs/heads/master@{#447598}
Committed: https://chromium.googlesource.com/chromium/src/+/ed703ecba76d77c8b8b389382c8d55f876cc772a

[dpapad, 2017-02-01 18:36:10]

Description was changed from

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is leaked (since
the tests no longer load a specific URL, but all URL requests are forwarded to
the top level document. Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

BUG=673825
==========

to

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is leaked (since
the tests no longer load a specific URL, but all URL requests are forwarded to
the top level document. Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-01 18:36:23]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 18:36:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-02-01 18:40:00]

Patchset #1 (id:1) has been deleted

[dpapad, 2017-02-01 18:40:24]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 18:40:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-02-01 18:48:52]

Description was changed from

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is leaked (since
the tests no longer load a specific URL, but all URL requests are forwarded to
the top level document. Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is leaked (since
the tests no longer load a specific URL, but all URL requests are forwarded to
the top level document. Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced (by adding PolymerTest.clearBody() and
detached() calls as necessary).

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-01 18:49:03]

Description was changed from

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is leaked (since
the tests no longer load a specific URL, but all URL requests are forwarded to
the top level document. Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced (by adding PolymerTest.clearBody() and
detached() calls as necessary).

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is leaked (since
the tests no longer load a specific URL, but all URL requests are forwarded to
the top level document. Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced (by adding PolymerTest.clearBody() and
detached() calls as necessary).

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-01 18:50:05]

Description was changed from

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is leaked (since
the tests no longer load a specific URL, but all URL requests are forwarded to
the top level document. Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced (by adding PolymerTest.clearBody() and
detached() calls as necessary).

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is present during
testing (since all browserPreload URL, are forwarded to the top level document.
Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced (by adding PolymerTest.clearBody() and
detached() calls as necessary).

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-01 18:50:22]

Description was changed from

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is present during
testing (since all browserPreload URL, are forwarded to the top level document.
Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced (by adding PolymerTest.clearBody() and
detached() calls as necessary).

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is present during
testing (since all browserPreload URLs, are forwarded to the top level document.
Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced (by adding PolymerTest.clearBody() and
detached() calls as necessary).

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-01 18:50:36]

Description was changed from

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is present during
testing (since all browserPreload URLs, are forwarded to the top level document.
Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced (by adding PolymerTest.clearBody() and
detached() calls as necessary).

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is present during
testing (since all browserPreload URLs are forwarded to the top level document.
Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced (by adding PolymerTest.clearBody() and
detached() calls as necessary).

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-01 19:17:26]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org

[dpapad, 2017-02-01 19:17:49]

Description was changed from

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is present during
testing (since all browserPreload URLs are forwarded to the top level document.
Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced (by adding PolymerTest.clearBody() and
detached() calls as necessary).

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is present during
testing, since all browserPreload URLs are forwarded to the top level document.
Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced (by adding PolymerTest.clearBody() and
detached() calls as necessary).

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2017-02-01 19:18:29]

Description was changed from

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is present during
testing, since all browserPreload URLs are forwarded to the top level document.
Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced (by adding PolymerTest.clearBody() and
detached() calls as necessary).

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is present during
testing, since all browserPreload URLs are forwarded to the top level document.
Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced, by adding PolymerTest.clearBody() and
detached() calls as necessary.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Dan Beam, 2017-02-01 19:19:01]

lgtm

[commit-bot: I haz the power, 2017-02-01 20:14:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 20:14:49]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-02-01 20:28:55]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-02-01 20:29:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 20:33:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485980935685050,
"parent_rev": "7dd42d9e138778bbc6af6c886175302d3f281e08", "commit_rev":
"ed703ecba76d77c8b8b389382c8d55f876cc772a"}

[commit-bot: I haz the power, 2017-02-01 20:37:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485980935685050,
"parent_rev": "7dd42d9e138778bbc6af6c886175302d3f281e08", "commit_rev":
"ed703ecba76d77c8b8b389382c8d55f876cc772a"}

[commit-bot: I haz the power, 2017-02-01 20:41:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1485980935685050,
"parent_rev": "7dd42d9e138778bbc6af6c886175302d3f281e08", "commit_rev":
"ed703ecba76d77c8b8b389382c8d55f876cc772a"}

[commit-bot: I haz the power, 2017-02-01 20:41:49]

Description was changed from

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is present during
testing, since all browserPreload URLs are forwarded to the top level document.
Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced, by adding PolymerTest.clearBody() and
detached() calls as necessary.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Fix some tests that break when run in Vulcanized mode.

When in Vulcanized mode, any global state across MD Settings is present during
testing, since all browserPreload URLs are forwarded to the top level document.
Examples of such global state are
 - CrSettingsPrefs.initialized
 - Route.initializeRouteFromUrlCalled_

Some tests rely on those global state vars to have a certain value, and
therefore
a way to reset their value is introduced, by adding PolymerTest.clearBody() and
detached() calls as necessary.

BUG=673825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2671493002
Cr-Commit-Position: refs/heads/master@{#447598}
Committed:
https://chromium.googlesource.com/chromium/src/+/ed703ecba76d77c8b8b389382c8d...
==========

[commit-bot: I haz the power, 2017-02-01 20:41:51]

Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ed703ecba76d77c8b8b389382c8d...