Support new --arc-availability flag.

Support new --arc-availability flag.

Current we have two flags, --enable-arc and --arc-available, but there
are two problems.
- "enable" is conflicting word in ARC. It is also used in
  preference, and meaning is actually different.
- Technically, --enable-arc without --arc-available is possible,
  but we expect the flags are tri state, no flags, only --arc-available,
  or both --enable-arc and --arc-available.
To reduce the complexity, we switch to unified flag --arc-availability.

BUG=b/34480289
TEST=Ran trybots.

Review-Url: https://codereview.chromium.org/2671463002
Cr-Commit-Position: refs/heads/master@{#448551}
Committed: https://chromium.googlesource.com/chromium/src/+/a53c2b460b8cbf587e4ba1abd7262297565d2eae

[hidehiko, 2017-02-01 06:12:50]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-01 06:13:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-01 06:50:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-01 06:50:48]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2017-02-01 06:51:45]

hidehiko@chromium.org changed reviewers:
+ yusukes@chromium.org

[hidehiko, 2017-02-01 06:51:45]

PTAL.

[hidehiko, 2017-02-02 08:58:44]

friendly ping?

[Yusuke Sato, 2017-02-02 18:14:06]

Sorry for the delay.

https://codereview.chromium.org/2671463002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc (right):

https://codereview.chromium.org/2671463002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc:883: // This
works partially, because sevices calling IsArcAvailable()
I'm not sure if I understand the comment... Do we need a TODO here?

https://codereview.chromium.org/2671463002/diff/1/chromeos/chromeos_switches.cc
File chromeos/chromeos_switches.cc (right):

https://codereview.chromium.org/2671463002/diff/1/chromeos/chromeos_switches....
chromeos/chromeos_switches.cc:69: // - installed: ARC is installed on this
device, but not officially supported.
.. The user can enable ARC only when it is enabled via base::Feature (aka
Finch.)

https://codereview.chromium.org/2671463002/diff/1/components/arc/arc_util_uni...
File components/arc/arc_util_unittest.cc (right):

https://codereview.chromium.org/2671463002/diff/1/components/arc/arc_util_uni...
components/arc/arc_util_unittest.cc:74: 
can you test "none"?

[hidehiko, 2017-02-03 15:37:41]

hidehiko@chromium.org changed reviewers:
+ xiyuan@chromium.org

[hidehiko, 2017-02-03 15:37:42]

Thank you for review, Yusuke. PTAL.
Xiyuan, PTAL for c/b/c/login?

https://codereview.chromium.org/2671463002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc (right):

https://codereview.chromium.org/2671463002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc:883: // This
works partially, because sevices calling IsArcAvailable()
On 2017/02/02 18:14:06, Yusuke Sato wrote:
> I'm not sure if I understand the comment... Do we need a TODO here?

Done.

https://codereview.chromium.org/2671463002/diff/1/chromeos/chromeos_switches.cc
File chromeos/chromeos_switches.cc (right):

https://codereview.chromium.org/2671463002/diff/1/chromeos/chromeos_switches....
chromeos/chromeos_switches.cc:69: // - installed: ARC is installed on this
device, but not officially supported.
On 2017/02/02 18:14:06, Yusuke Sato wrote:
> .. The user can enable ARC only when it is enabled via base::Feature (aka
> Finch.)

Done. I'd like to avoid "enable" for Finch so reworded. WDYT?

https://codereview.chromium.org/2671463002/diff/1/components/arc/arc_util_uni...
File components/arc/arc_util_unittest.cc (right):

https://codereview.chromium.org/2671463002/diff/1/components/arc/arc_util_uni...
components/arc/arc_util_unittest.cc:74: 
On 2017/02/02 18:14:06, Yusuke Sato wrote:
> can you test "none"?

Done.

[Yusuke Sato, 2017-02-03 19:19:02]

lgtm with one more comment here and another at b/34480289#comment9.

https://codereview.chromium.org/2671463002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc (right):

https://codereview.chromium.org/2671463002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc:884: // before
Kiosk log-in does not work.
Any user-visible issues here? Please document if any (and please also file a
bug.)

[xiyuan, 2017-02-03 22:35:17]

lgtm

Please make sure poromov@ is aware of the TODO in ArcKioskAppLoggedIn.

[Sergey Poromov, 2017-02-03 22:58:57]

poromov@chromium.org changed reviewers:
+ poromov@chromium.org

[Sergey Poromov, 2017-02-03 22:58:57]

https://codereview.chromium.org/2671463002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc (right):

https://codereview.chromium.org/2671463002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc:884: // before
Kiosk log-in does not work.
On 2017/02/03 19:19:02, Yusuke Sato wrote:
> Any user-visible issues here? Please document if any (and please also file a
> bug.)

Generally, this line should be removed from here. However, there will be some
work around ARC++ Kiosk and kArcAvailability after this CL (~next week), so I'll
made the cleanup there.

[hidehiko, 2017-02-06 05:01:58]

The CQ bit was checked by hidehiko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 05:02:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 05:42:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 05:42:48]

Dry run: This issue passed the CQ dry run.

[hidehiko, 2017-02-07 04:50:50]

As for naming, I changed the value to officially-supported as we agreed on the
bug.

So, landing. Thank you very much for the review.

https://codereview.chromium.org/2671463002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc (right):

https://codereview.chromium.org/2671463002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc:884: // before
Kiosk log-in does not work.
On 2017/02/03 19:19:02, Yusuke Sato wrote:
> Any user-visible issues here? Please document if any (and please also file a
> bug.)

Done.

[hidehiko, 2017-02-07 04:51:00]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2017-02-07 04:51:01]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org,
yusukes@chromium.org
Link to the patchset: https://codereview.chromium.org/2671463002/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-07 04:51:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 04:56:02]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486443060735430,
"parent_rev": "934271eaabb521f8d19d016801459f9ae9eb7ad5", "commit_rev":
"a53c2b460b8cbf587e4ba1abd7262297565d2eae"}

[commit-bot: I haz the power, 2017-02-07 04:56:33]

Description was changed from

==========
Support new --arc-availability flag.

Current we have two flags, --enable-arc and --arc-available, but there
are two problems.
- "enable" is conflicting word in ARC. It is also used in
  preference, and meaning is actually different.
- Technically, --enable-arc without --arc-available is possible,
  but we expect the flags are tri state, no flags, only --arc-available,
  or both --enable-arc and --arc-available.
To reduce the complexity, we switch to unified flag --arc-availability.

BUG=b/34480289
TEST=Ran trybots.
==========

to

==========
Support new --arc-availability flag.

Current we have two flags, --enable-arc and --arc-available, but there
are two problems.
- "enable" is conflicting word in ARC. It is also used in
  preference, and meaning is actually different.
- Technically, --enable-arc without --arc-available is possible,
  but we expect the flags are tri state, no flags, only --arc-available,
  or both --enable-arc and --arc-available.
To reduce the complexity, we switch to unified flag --arc-availability.

BUG=b/34480289
TEST=Ran trybots.

Review-Url: https://codereview.chromium.org/2671463002
Cr-Commit-Position: refs/heads/master@{#448551}
Committed:
https://chromium.googlesource.com/chromium/src/+/a53c2b460b8cbf587e4ba1abd726...
==========

[commit-bot: I haz the power, 2017-02-07 04:56:34]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a53c2b460b8cbf587e4ba1abd726...