Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 2671383003: [Telemetry] Migrate browser_test_runner to use typ as the test runner (Closed)

Created:
3 years, 10 months ago by nednguyen
Modified:
3 years, 10 months ago
Reviewers:
Dirk Pranke
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Migrate browser_test_runner to use typ as the test runner This is a reland of https://codereview.chromium.org/2671483002/. The previous work was reverted to test out the change to gpu tests in chromium repo. Patch 1 is the original work, patch 2 & beyond includes fix for TearDownProcess BUG=chromium:636153 TBR=kbr@chromium.org Review-Url: https://codereview.chromium.org/2671383003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/12bf6ba0611a7c58086e665844f0fbf3321b578a

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix the call for TearDownProcess #

Unified diffs Side-by-side diffs Delta from patch set Stats (+475 lines, -547 lines) Patch
M telemetry/bin/run_browser_tests View 1 chunk +1 line, -2 lines 0 comments Download
M telemetry/examples/browser_tests/failed_tests.py View 2 chunks +2 lines, -2 lines 0 comments Download
A + telemetry/examples/browser_tests/process_tests.py View 2 chunks +17 lines, -11 lines 0 comments Download
A telemetry/examples/browser_tests/sample_unittest.py View 1 chunk +12 lines, -0 lines 0 comments Download
M telemetry/examples/browser_tests/simple_browser_test.py View 1 chunk +2 lines, -2 lines 0 comments Download
A telemetry/telemetry/testing/browser_test_context.py View 1 chunk +74 lines, -0 lines 0 comments Download
M telemetry/telemetry/testing/browser_test_runner.py View 1 chunk +32 lines, -308 lines 0 comments Download
M telemetry/telemetry/testing/browser_test_runner_unittest.py View 10 chunks +156 lines, -105 lines 0 comments Download
A + telemetry/telemetry/testing/run_browser_tests.py View 1 5 chunks +153 lines, -109 lines 0 comments Download
M telemetry/telemetry/testing/serially_executed_browser_test_case.py View 4 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
nednguyen
https://codereview.chromium.org/2671383003/diff/1/telemetry/telemetry/testing/run_browser_tests.py File telemetry/telemetry/testing/run_browser_tests.py (right): https://codereview.chromium.org/2671383003/diff/1/telemetry/telemetry/testing/run_browser_tests.py#newcode352 telemetry/telemetry/testing/run_browser_tests.py:352: context.test_class.TearDownProcess() This is the bug. context were deleted & ...
3 years, 10 months ago (2017-02-07 00:43:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671383003/20001
3 years, 10 months ago (2017-02-07 00:44:08 UTC) #5
nednguyen
On 2017/02/07 00:43:39, nednguyen wrote: > https://codereview.chromium.org/2671383003/diff/1/telemetry/telemetry/testing/run_browser_tests.py > File telemetry/telemetry/testing/run_browser_tests.py (right): > > https://codereview.chromium.org/2671383003/diff/1/telemetry/telemetry/testing/run_browser_tests.py#newcode352 > ...
3 years, 10 months ago (2017-02-07 00:44:34 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/12bf6ba0611a7c58086e665844f0fbf3321b578a
3 years, 10 months ago (2017-02-07 01:05:20 UTC) #9
nednguyen
3 years, 10 months ago (2017-02-07 01:08:55 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2681453003/ by nednguyen@google.com.

The reason for reverting is: Revert to try out the change in Chromium CQ.

Powered by Google App Engine
This is Rietveld 408576698