Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 2671363002: [ObjC ARC] Converts ios/chrome/browser/ui/ntp:eg_tests to ARC. (Closed)

Created:
3 years, 10 months ago by lody
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[ObjC ARC] Converts ios/chrome/browser/ui/ntp:eg_tests to ARC. Automatically generated ARCMigrate commit Notable issues:None BUG=624363 TEST=None Review-Url: https://codereview.chromium.org/2671363002 Cr-Commit-Position: refs/heads/master@{#448257} Committed: https://chromium.googlesource.com/chromium/src/+/edc1e9058dbd3c582b9f8e0f94a450db5bc05cb8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M ios/chrome/browser/ui/ntp/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/ntp/new_tab_page_egtest.mm View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
lody
Please🙏 review🌈
3 years, 10 months ago (2017-02-06 15:10:37 UTC) #4
marq (ping after 24h)
lgtm
3 years, 10 months ago (2017-02-06 15:32:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671363002/1
3 years, 10 months ago (2017-02-06 15:35:42 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-06 15:40:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/edc1e9058dbd3c582b9f8e0f94a4...

Powered by Google App Engine
This is Rietveld 408576698