Add UMA.IsClonedInstall boolean histogram.

Add UMA.IsClonedInstall boolean histogram.

This is logged with a value of true when we believe this is a
cloned install (via the ClonedInstallDetector). Logged with
every UMA log, but only with a value of true to avoid extra
data use for normal cases.

BUG=689053
Review-Url: https://codereview.chromium.org/2671333003
Cr-Commit-Position: refs/heads/master@{#448286}
Committed: https://chromium.googlesource.com/chromium/src/+/1359e8d0122000cf132ddd464580ccfee8f587da

[Alexei Svitkine (slow), 2017-02-06 15:24:30]

The CQ bit was checked by asvitkine@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 15:24:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Alexei Svitkine (slow), 2017-02-06 15:24:50]

asvitkine@chromium.org changed reviewers:
+ jwd@chromium.org, rkaplow@chromium.org

[jwd, 2017-02-06 15:42:05]

lgtm

https://codereview.chromium.org/2671333003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2671333003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:70773: +<histogram
name="UMA.IsClonedInstall" enum="Boolean">
Maybe a more precise enum?

[commit-bot: I haz the power, 2017-02-06 16:20:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 16:20:04]

Dry run: This issue passed the CQ dry run.

[rkaplow, 2017-02-06 16:20:27]

https://codereview.chromium.org/2671333003/diff/1/components/metrics/metrics_...
File components/metrics/metrics_log.cc (right):

https://codereview.chromium.org/2671333003/diff/1/components/metrics/metrics_...
components/metrics/metrics_log.cc:301:
UMA_HISTOGRAM_BOOLEAN("UMA.IsClonedInstall", true);
what about reporting the false case? You think not worth it?

https://codereview.chromium.org/2671333003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2671333003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:70773: +<histogram
name="UMA.IsClonedInstall" enum="Boolean">
On 2017/02/06 15:42:05, jwd wrote:
> Maybe a more precise enum?

hah :|

[Alexei Svitkine (slow), 2017-02-06 16:26:03]

https://codereview.chromium.org/2671333003/diff/1/components/metrics/metrics_...
File components/metrics/metrics_log.cc (right):

https://codereview.chromium.org/2671333003/diff/1/components/metrics/metrics_...
components/metrics/metrics_log.cc:301:
UMA_HISTOGRAM_BOOLEAN("UMA.IsClonedInstall", true);
On 2017/02/06 16:20:26, rkaplow wrote:
> what about reporting the false case? You think not worth it?

I discuss this in the CL description.

I don't think it warrants the banwidth use for everyone else. Also, with the new
changes to user counts toggle on histograms dashboard that YK is making, we can
easily compare to all record counts.

[Alexei Svitkine (slow), 2017-02-06 16:28:49]

https://codereview.chromium.org/2671333003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2671333003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:70773: +<histogram
name="UMA.IsClonedInstall" enum="Boolean">
On 2017/02/06 16:20:26, rkaplow wrote:
> On 2017/02/06 15:42:05, jwd wrote:
> > Maybe a more precise enum?
> 
> hah :|

Done.

[Alexei Svitkine (slow), 2017-02-06 16:29:54]

The CQ bit was checked by asvitkine@chromium.org

[Alexei Svitkine (slow), 2017-02-06 16:29:54]

The patchset sent to the CQ was uploaded after l-g-t-m from jwd@chromium.org
Link to the patchset: https://codereview.chromium.org/2671333003/#ps20001
(title: "Add new enum.")

[commit-bot: I haz the power, 2017-02-06 16:30:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rkaplow, 2017-02-06 16:32:27]

lgtm

[commit-bot: I haz the power, 2017-02-06 17:37:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486398594274640,
"parent_rev": "68c2b21598d1ffb959056909f6b4fa8bf7a17155", "commit_rev":
"1359e8d0122000cf132ddd464580ccfee8f587da"}

[commit-bot: I haz the power, 2017-02-06 17:38:16]

Description was changed from

==========
Add UMA.IsClonedInstall boolean histogram.

This is logged with a value of true when we believe this is a
cloned install (via the ClonedInstallDetector). Logged with
every UMA log, but only with a value of true to avoid extra
data use for normal cases.

BUG=689053
==========

to

==========
Add UMA.IsClonedInstall boolean histogram.

This is logged with a value of true when we believe this is a
cloned install (via the ClonedInstallDetector). Logged with
every UMA log, but only with a value of true to avoid extra
data use for normal cases.

BUG=689053

Review-Url: https://codereview.chromium.org/2671333003
Cr-Commit-Position: refs/heads/master@{#448286}
Committed:
https://chromium.googlesource.com/chromium/src/+/1359e8d0122000cf132ddd464580...
==========

[commit-bot: I haz the power, 2017-02-06 17:38:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1359e8d0122000cf132ddd464580...