Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 267133004: Fix link error when building component build on OS X with OpenSSL. (Closed)

Created:
6 years, 7 months ago by haavardm
Modified:
6 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix link error when building component build on OS X with OpenSSL. Don't build base/keygen_handler_openssl.cc when using OpenSSL while leaving certificate handling to the OS. Keygen handler will in these cases be implemented in OS specific code. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268808

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/net.gyp View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
haavardm
Ryan: Quick fix for link error mentioned by David in https://codereview.chromium.org/263743004/
6 years, 7 months ago (2014-05-06 16:05:11 UTC) #1
Ryan Sleevi
lgtm
6 years, 7 months ago (2014-05-06 18:42:05 UTC) #2
haavardm
The CQ bit was checked by haavardm@opera.com
6 years, 7 months ago (2014-05-06 18:42:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haavardm@opera.com/267133004/1
6 years, 7 months ago (2014-05-06 18:44:40 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-07 06:03:59 UTC) #5
haavardm
The CQ bit was unchecked by haavardm@opera.com
6 years, 7 months ago (2014-05-07 07:34:46 UTC) #6
haavardm
The CQ bit was checked by haavardm@opera.com
6 years, 7 months ago (2014-05-07 07:34:47 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haavardm@opera.com/267133004/1
6 years, 7 months ago (2014-05-07 07:38:03 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-07 16:28:28 UTC) #9
Message was sent while issue was closed.
Change committed as 268808

Powered by Google App Engine
This is Rietveld 408576698