Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 263743004: When building OpenSSL as a component build on OS X, by default export all symbols (matching Linux) (Closed)

Created:
6 years, 7 months ago by Ryan Sleevi
Modified:
6 years, 7 months ago
Reviewers:
davidben
CC:
chromium-reviews
Visibility:
Public.

Description

When building OpenSSL as a component build on OS X, by default export all symbols (matching Linux) BUG=none R=davidben@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M openssl.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ryan Sleevi
David: Easy fix for component builds haavard: FYI. I suspect you've been doing your OS ...
6 years, 7 months ago (2014-05-01 00:48:47 UTC) #1
haavardm
On 2014/05/01 00:48:47, Ryan Sleevi wrote: > haavard: FYI. I suspect you've been doing your ...
6 years, 7 months ago (2014-05-01 07:27:41 UTC) #2
davidben
LGTM. I get a different compile failure now (OpenSSLPrivateKeyStore), but that seems more expected since ...
6 years, 7 months ago (2014-05-01 16:14:52 UTC) #3
Ryan Sleevi
The CQ bit was checked by rsleevi@chromium.org
6 years, 7 months ago (2014-05-01 16:15:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rsleevi@chromium.org/263743004/1
6 years, 7 months ago (2014-05-01 16:15:53 UTC) #5
commit-bot: I haz the power
Change committed as 267524
6 years, 7 months ago (2014-05-01 16:16:04 UTC) #6
haavardm
6 years, 7 months ago (2014-05-05 11:46:18 UTC) #7
Message was sent while issue was closed.
On 2014/05/01 16:16:04, I haz the power (commit-bot) wrote:
> Change committed as 267524

David: I assume you mean this one?

"net::OpenSSLPrivateKeyStore::StoreKeyPair(GURL const&, evp_pkey_st*)",
referenced from:
    net::KeygenHandler::GenKeyAndSignChallenge() in net.keygen_handler_openssl.o
ld: symbol(s) not found for architecture i386

That compile error does not happen when doing static build, that's why I haven't
seen it. I believe the reason is that KeygenHandler::GenKeyAndSignChallenge() is
not actually used, and thus removed during optimization before linking when
doing static build.

I guess a short term fix would be to compile openssl_private_key_store_memory.cc
for OS X.

Powered by Google App Engine
This is Rietveld 408576698