Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2671323003: Fix the size of omnibox suggestion answers. (Closed)

Created:
3 years, 10 months ago by Justin Donnelly
Modified:
3 years, 10 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

Fix the size of omnibox suggestion answers. Through a confluence of various changes, OmniboxResultView got into a state where the height given to answers is always the largest size but the actual font used is the regular font size. This fix ensures that both the size of the font and the space it's given are driven by the data in the answer. For the currently launched answers, this is always the largest size so they're being shown too small. But this fix will also support upcoming answer types that don't use the largest font size. BUG=685714 Review-Url: https://codereview.chromium.org/2654163005 Cr-Commit-Position: refs/heads/master@{#447702} (cherry picked from commit 5fdae6fa2582b407ad6281c152e5cb6f7b95a391) Review-Url: https://codereview.chromium.org/2671323003 . Cr-Commit-Position: refs/branch-heads/2987@{#334} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/738b5637aa3218e44f5a29ea9412a69efc26e2a3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -11 lines) Patch
M chrome/browser/ui/views/omnibox/omnibox_result_view.h View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 6 chunks +36 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Justin Donnelly
3 years, 10 months ago (2017-02-06 18:11:44 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
738b5637aa3218e44f5a29ea9412a69efc26e2a3.

Powered by Google App Engine
This is Rietveld 408576698