Replace OnMemoryStateChange() with OnPurgeMemory() in dom_storage

Replace OnMemoryStateChange() with OnPurgeMemory() in dom_storage

We added OnPurgeMemory() callback to MemoryCoordinatorClient so that we
can separate memory purging from memory state transition (See [1] for
the motivation of this separation). This CL replaces OnMemoryStateChange()
with OnPurgeMemory() in DOMStorageContextWrapper because it just purges
memory.

[1] https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/project-trim/s96xSirL2Hs/18uq1zfHEgAJ

BUG=684287
Review-Url: https://codereview.chromium.org/2671303004
Cr-Commit-Position: refs/heads/master@{#450242}
Committed: https://chromium.googlesource.com/chromium/src/+/492af7d3b599bf9e2a407d7e55e35617854c4e32

[bashi, 2017-02-07 01:27:31]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 01:28:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 02:20:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 02:20:34]

Dry run: This issue passed the CQ dry run.

[bashi, 2017-02-07 02:22:17]

bashi@chromium.org changed reviewers:
+ michaeln@chromium.org

[bashi, 2017-02-07 02:22:17]

michaeln@: PTAL

[bashi, 2017-02-10 02:35:14]

michaeln@: Friendly ping :)

[bashi, 2017-02-14 00:10:33]

bashi@chromium.org changed reviewers:
+ mek@chromium.org

[bashi, 2017-02-14 00:10:34]

mek@: Could you review this?

[Marijn Kruisselbrink, 2017-02-14 00:39:45]

lgtm

related question, since I'm working on rewriting all this and trying to figure
out how best to integrate with the various memory pressure bits, will there ever
be something similar to the critical/non-critical distinction that is used in
the memory pressure listener to distinguish between the two different levels of
purging?

[bashi, 2017-02-14 01:53:14]

Thanks for review!

On 2017/02/14 00:39:45, Marijn Kruisselbrink wrote:
> lgtm
> 
> related question, since I'm working on rewriting all this and trying to figure
> out how best to integrate with the various memory pressure bits, will there
ever
> be something similar to the critical/non-critical distinction that is used in
> the memory pressure listener to distinguish between the two different levels
of
> purging?

We've discussed whether we should add pressure levels. Our current plan is to
start without levels and add them if it's really needed. We may introduce
pressure levels to OnPurgeMemory() in the future, but currently we don't plan to
do it.

[bashi, 2017-02-14 01:53:22]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2017-02-14 01:54:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-14 04:21:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487037202659010, "parent_rev":
"452a477ff34a2af79a882b44ccc1939230c9e527", "commit_rev":
"492af7d3b599bf9e2a407d7e55e35617854c4e32"}

[commit-bot: I haz the power, 2017-02-14 04:22:11]

Description was changed from

==========
Replace OnMemoryStateChange() with OnPurgeMemory() in dom_storage

We added OnPurgeMemory() callback to MemoryCoordinatorClient so that we
can separate memory purging from memory state transition (See [1] for
the motivation of this separation). This CL replaces OnMemoryStateChange()
with OnPurgeMemory() in DOMStorageContextWrapper because it just purges
memory.

[1]
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=f...

BUG=684287
==========

to

==========
Replace OnMemoryStateChange() with OnPurgeMemory() in dom_storage

We added OnPurgeMemory() callback to MemoryCoordinatorClient so that we
can separate memory purging from memory state transition (See [1] for
the motivation of this separation). This CL replaces OnMemoryStateChange()
with OnPurgeMemory() in DOMStorageContextWrapper because it just purges
memory.

[1]
https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=f...

BUG=684287

Review-Url: https://codereview.chromium.org/2671303004
Cr-Commit-Position: refs/heads/master@{#450242}
Committed:
https://chromium.googlesource.com/chromium/src/+/492af7d3b599bf9e2a407d7e55e3...
==========

[commit-bot: I haz the power, 2017-02-14 04:22:11]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/492af7d3b599bf9e2a407d7e55e3...