Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2671213003: BodyStreamBuffer should take care the case where endRead returns Done (Closed)

Created:
3 years, 10 months ago by yhirano
Modified:
3 years, 10 months ago
Reviewers:
hiroshige
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

BodyStreamBuffer should take care the case where endRead returns Done BytesConsumer::endRead may return Done, which means that in the function it finds there is no more data. BodyStreamBuffer::processData incorrectly dropped the data in such a case. This CL fixes that. BUG=688922 R=hiroshige@chromium.org Review-Url: https://codereview.chromium.org/2671213003 Cr-Commit-Position: refs/heads/master@{#449947} Committed: https://chromium.googlesource.com/chromium/src/+/28ff32abc83ae8939f56702151b3d982859d56b5

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -9 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/fetch/script-tests/response.js View 1 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/BodyStreamBuffer.cpp View 1 2 1 chunk +11 lines, -9 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (12 generated)
yhirano
3 years, 10 months ago (2017-02-06 06:48:59 UTC) #7
hiroshige
lgtm
3 years, 10 months ago (2017-02-06 19:05:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671213003/40001
3 years, 10 months ago (2017-02-13 12:32:15 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 14:10:04 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/28ff32abc83ae8939f56702151b3...

Powered by Google App Engine
This is Rietveld 408576698