Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2671103002: Implement host settings migration. (Closed)

Created:
3 years, 10 months ago by Jamie
Modified:
3 years, 10 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement host settings migration. This CL adds support for external messages, asynchronous handlers and a getSettings message. It also tightens the default externally_connectable to deny access to the new API to all origins, including other extensions, for the time being. Review-Url: https://codereview.chromium.org/2671103002 Cr-Commit-Position: refs/heads/master@{#448128} Committed: https://chromium.googlesource.com/chromium/src/+/9760c9890b917e02136c6d32f89fd1a432c17d8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -15 lines) Patch
M remoting/webapp/base/js/ipc.js View 5 chunks +31 lines, -14 lines 0 comments Download
M remoting/webapp/base/js/ipc_unittest.js View 2 chunks +39 lines, -1 line 0 comments Download
M remoting/webapp/crd/js/background.js View 2 chunks +3 lines, -0 lines 0 comments Download
A remoting/webapp/crd/js/options_export.js View 1 chunk +30 lines, -0 lines 0 comments Download
M remoting/webapp/crd/manifest.json.jinja2 View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/webapp/files.gni View 1 chunk +1 line, -0 lines 0 comments Download
M remoting/webapp/js_proto/chrome_mocks.js View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jamie
PTAL
3 years, 10 months ago (2017-02-03 22:43:09 UTC) #2
kelvinp
lgtm
3 years, 10 months ago (2017-02-03 22:54:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671103002/1
3 years, 10 months ago (2017-02-03 23:16:40 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-04 00:49:30 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9760c9890b917e02136c6d32f89f...

Powered by Google App Engine
This is Rietveld 408576698