Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2671063002: Remove FixedSizedScrollView. (Closed)

Created:
3 years, 10 months ago by Evan Stade
Modified:
3 years, 10 months ago
Reviewers:
tdanderson
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, shuchen+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove FixedSizedScrollView. In MD it was equivalent to a normal views::ScrollView, so this should not change any behaviors. BUG=686291 Review-Url: https://codereview.chromium.org/2671063002 Cr-Commit-Position: refs/heads/master@{#448791} Committed: https://chromium.googlesource.com/chromium/src/+/252bd536aff3249ae046eec0be35b4fc60995756

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -191 lines) Patch
M ash/BUILD.gn View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/audio/audio_detailed_view.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/bluetooth/tray_bluetooth.cc View 1 3 chunks +2 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/cast/tray_cast.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/common/system/chromeos/ime_menu/ime_menu_tray.cc View 1 3 chunks +2 lines, -14 lines 0 comments Download
M ash/common/system/chromeos/network/network_state_list_detailed_view.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M ash/common/system/chromeos/network/tray_sms.cc View 2 chunks +1 line, -1 line 0 comments Download
D ash/common/system/tray/fixed_sized_scroll_view.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ash/common/system/tray/fixed_sized_scroll_view.cc View 1 chunk +0 lines, -85 lines 0 comments Download
M ash/common/system/tray/tray_details_view.h View 1 4 chunks +3 lines, -3 lines 0 comments Download
M ash/common/system/tray/tray_details_view.cc View 1 3 chunks +4 lines, -35 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Evan Stade
will hold off on committing till next week.
3 years, 10 months ago (2017-02-03 21:23:28 UTC) #4
tdanderson
LGTM in advance
3 years, 10 months ago (2017-02-06 21:00:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671063002/1
3 years, 10 months ago (2017-02-07 18:15:23 UTC) #9
commit-bot: I haz the power
Failed to apply patch for ash/common/system/tray/tray_details_view.h: While running git apply --index -p1; error: patch failed: ...
3 years, 10 months ago (2017-02-07 19:29:52 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2671063002/20001
3 years, 10 months ago (2017-02-07 21:52:50 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 23:40:47 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/252bd536aff3249ae046eec0be35...

Powered by Google App Engine
This is Rietveld 408576698