Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1017)

Unified Diff: chrome/common/custom_handlers/protocol_handler.h

Issue 267103002: Ignore title parameter for navigator.registerProtocolHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/custom_handlers/protocol_handler.h
diff --git a/chrome/common/custom_handlers/protocol_handler.h b/chrome/common/custom_handlers/protocol_handler.h
index dc18be53e859c3980968155e1ffb6d24b83eff80..745a3f52d5a67caaff9d1b19b11f83cc9b45f7c1 100644
--- a/chrome/common/custom_handlers/protocol_handler.h
+++ b/chrome/common/custom_handlers/protocol_handler.h
@@ -10,14 +10,13 @@
#include "base/values.h"
#include "url/gurl.h"
-// A single tuple of (protocol, url, title) that indicates how URLs of the
+// A single tuple of (protocol, url) that indicates how URLs of the
// given protocol should be rewritten to be handled.
class ProtocolHandler {
public:
static ProtocolHandler CreateProtocolHandler(const std::string& protocol,
- const GURL& url,
- const base::string16& title);
+ const GURL& url);
// Creates a ProtocolHandler with fields from the dictionary. Returns an
// empty ProtocolHandler if the input is invalid.
@@ -48,7 +47,6 @@ class ProtocolHandler {
const std::string& protocol() const { return protocol_; }
const GURL& url() const { return url_;}
- const base::string16& title() const { return title_; }
bool IsEmpty() const {
return protocol_.empty();
@@ -65,13 +63,11 @@ class ProtocolHandler {
private:
ProtocolHandler(const std::string& protocol,
- const GURL& url,
- const base::string16& title);
+ const GURL& url);
ProtocolHandler();
std::string protocol_;
GURL url_;
- base::string16 title_;
};
#endif // CHROME_COMMON_CUSTOM_HANDLERS_PROTOCOL_HANDLER_H_
« no previous file with comments | « chrome/browser/ui/webui/options/handler_options_handler.cc ('k') | chrome/common/custom_handlers/protocol_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698