Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Unified Diff: chrome/browser/ui/webui/options/handler_options_handler.cc

Issue 267103002: Ignore title parameter for navigator.registerProtocolHandler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/handler_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/handler_options_handler.cc b/chrome/browser/ui/webui/options/handler_options_handler.cc
index 4c8dfc7c6dbaded94678bd8580e7d2d34468ede5..456f4694e2bb5399103ab7d48d3be5565aece8e0 100644
--- a/chrome/browser/ui/webui/options/handler_options_handler.cc
+++ b/chrome/browser/ui/webui/options/handler_options_handler.cc
@@ -99,7 +99,7 @@ static void GetHandlersAsListValue(
base::ListValue* handlerValue = new base::ListValue();
handlerValue->Append(new base::StringValue(handler->protocol()));
handlerValue->Append(new base::StringValue(handler->url().spec()));
- handlerValue->Append(new base::StringValue(handler->title()));
+ handlerValue->Append(new base::StringValue(handler->url().host()));
handler_list->Append(handlerValue);
}
}
@@ -199,14 +199,11 @@ ProtocolHandler HandlerOptionsHandler::ParseHandlerFromArgs(
const base::ListValue* args) const {
base::string16 protocol;
base::string16 url;
- base::string16 title;
- bool ok = args->GetString(0, &protocol) && args->GetString(1, &url) &&
- args->GetString(2, &title);
+ bool ok = args->GetString(0, &protocol) && args->GetString(1, &url);
if (!ok)
return ProtocolHandler::EmptyProtocolHandler();
return ProtocolHandler::CreateProtocolHandler(base::UTF16ToUTF8(protocol),
- GURL(base::UTF16ToUTF8(url)),
- title);
+ GURL(base::UTF16ToUTF8(url)));
}
void HandlerOptionsHandler::Observe(

Powered by Google App Engine
This is Rietveld 408576698