Fix punctuation of several Page Info strings

Fix punctuation of several Page Info strings

BUG=688621
Review-Url: https://codereview.chromium.org/2670993003
Cr-Commit-Position: refs/heads/master@{#448349}
Committed: https://chromium.googlesource.com/chromium/src/+/f002ed5e3050d1936d914d18495fcb20905820a4

[meacer, 2017-02-04 01:47:58]

meacer@chromium.org changed reviewers:
+ lgarron@chromium.org

[chromium-reviews, 2017-02-04 02:51:15]

Not LGTM; these are intentionally phrases and not sentences.

(They should be in color to stand out, but they are not yet.)
On Fri, Feb 3, 2017 at 17:48 <meacer@chromium.org> wrote:

> Reviewers: lgarron
> CL: https://codereview.chromium.org/2670993003/
>
> Description:
> Fix punctuation of several Page Info strings
>
> BUG=688621
>
> Affected files (+4, -4 lines):
> M chrome/app/chromium_strings.grd
> M chrome/app/google_chrome_strings.grd
> M components/pageinfo_strings.grdp
>
>
> Index: chrome/app/chromium_strings.grd
> diff --git a/chrome/app/chromium_strings.grd
> b/chrome/app/chromium_strings.grd
> index
>
bbe57ab30d43d44f43a433f8e119354bdc400944..2ecd90f18686906ae5f5f6003c0c14af67e4527a
> 100644
> --- a/chrome/app/chromium_strings.grd
> +++ b/chrome/app/chromium_strings.grd
> @@ -990,7 +990,7 @@ Please check your email at <ph
> name="ACCOUNT_EMAIL">$2<ex>jane.doe@example.com</
>
> <!-- Website Settings bubble -->
> <message name="IDS_WEBSITE_SETTINGS_INTERNAL_PAGE" desc="Text that is
> displayed in the header of the Website Settings popup if the page was
> generated by Chrome itself.">
> - You are viewing a secure Chromium page.
> + You're viewing a secure Chromium page
> </message>
>
> <!-- Webstore strings -->
> Index: chrome/app/google_chrome_strings.grd
> diff --git a/chrome/app/google_chrome_strings.grd
> b/chrome/app/google_chrome_strings.grd
> index
>
ba91e807362718507253e8d556afdaa51681c972..8a9d67216189847f9bb25171bfe5fd7624abc34b
> 100644
> --- a/chrome/app/google_chrome_strings.grd
> +++ b/chrome/app/google_chrome_strings.grd
> @@ -991,7 +991,7 @@ Please check your email at <ph
> name="ACCOUNT_EMAIL">$2<ex>jane.doe@example.com</
>
> <!-- Website Settings bubble -->
> <message name="IDS_WEBSITE_SETTINGS_INTERNAL_PAGE" desc="Text that is
> displayed in the header of the Website Settings popup if the page was
> generated by Chrome itself.">
> - You are viewing a secure Google Chrome page.
> + You're viewing a secure Google Chrome page
> </message>
>
> <!-- Webstore strings -->
> Index: components/pageinfo_strings.grdp
> diff --git a/components/pageinfo_strings.grdp
> b/components/pageinfo_strings.grdp
> index
>
d5246fa4098bdf5b113f95afe300bb18672a918c..f5cacbe480cfa0f068966664ea740edc3bc581af
> 100644
> --- a/components/pageinfo_strings.grdp
> +++ b/components/pageinfo_strings.grdp
> @@ -92,10 +92,10 @@
> Your connection to <ph name="DOMAIN">$1<ex>www.google.com</ex></ph> is
> encrypted using an obsolete cipher suite.
> </message>
> <message name="IDS_PAGE_INFO_EXTENSION_PAGE" desc="Message to display in
> the page info bubble when the page you are on is a chrome-extension://
> page. This refers to Chrome extensions.">
> - You are viewing an extension page.
> + You're viewing an extension page
> </message>
> <message name="IDS_PAGE_INFO_VIEW_SOURCE_PAGE" desc="Message to display in
> the page info bubble when you are viewing page sources by using |View page
> source| option from the right click menu.">
> - You are viewing the source of a web page.
> + You're viewing the source of a web page
> </message>
>
> <if expr="not use_titlecase">
>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[meacer, 2017-02-04 18:40:51]

This isn't my decision, it's from the UI team. I'll cc you in the thread.

[lgarron, 2017-02-06 00:09:58]

On 2017/02/04 at 18:40:51, meacer wrote:
> This isn't my decision, it's from the UI team. I'll cc you in the thread.

Oh, I'm sorry. I had read the diffs in the wrong direction.
Removing punctuation. This is actually the right direction. LGTM.

[meacer, 2017-02-06 18:40:32]

No problem!

[meacer, 2017-02-06 18:40:36]

The CQ bit was checked by meacer@chromium.org

[commit-bot: I haz the power, 2017-02-06 18:41:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 19:30:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486406436028050, "parent_rev":
"19f104a391020bf6538f3fc78ce3c022096796ae", "commit_rev":
"f002ed5e3050d1936d914d18495fcb20905820a4"}

[commit-bot: I haz the power, 2017-02-06 19:31:34]

Description was changed from

==========
Fix punctuation of several Page Info strings

BUG=688621
==========

to

==========
Fix punctuation of several Page Info strings

BUG=688621

Review-Url: https://codereview.chromium.org/2670993003
Cr-Commit-Position: refs/heads/master@{#448349}
Committed:
https://chromium.googlesource.com/chromium/src/+/f002ed5e3050d1936d914d18495f...
==========

[commit-bot: I haz the power, 2017-02-06 19:31:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f002ed5e3050d1936d914d18495f...