Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 2670983004: [WebViewLayoutTests] update/document not-webview-exposed interfaces (Closed)

Created:
3 years, 10 months ago by timvolodine
Modified:
3 years, 10 months ago
Reviewers:
Torne
CC:
chromium-reviews, android-webview-reviews_chromium.org, Tobias Sargeant
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebViewLayoutTests] update/document not-webview-exposed interfaces Update links to crbugs and provide more documentation as to why the listed interfaces are not exposed in WebView. BUG=689632, 506603 Review-Url: https://codereview.chromium.org/2670983004 Cr-Commit-Position: refs/heads/master@{#448720} Committed: https://chromium.googlesource.com/chromium/src/+/87434c433441746588f5ee22822fdc422a04e225

Patch Set 1 #

Patch Set 2 : correction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -27 lines) Patch
M android_webview/tools/system_webview_shell/test/data/webexposed/not-webview-exposed.txt View 1 4 chunks +28 lines, -27 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
timvolodine
3 years, 10 months ago (2017-02-04 03:46:18 UTC) #2
Torne
lgtm
3 years, 10 months ago (2017-02-06 12:11:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2670983004/20001
3 years, 10 months ago (2017-02-07 19:29:27 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 20:27:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/87434c433441746588f5ee22822f...

Powered by Google App Engine
This is Rietveld 408576698