MD Settings: in spell-check page, disable add button when input is empty.

chrome/test/data/webui/settings/languages_page_browsertest.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for settings-languages-page. */
 
 /** @const {string} Path to root from chrome/test/data/webui/settings/. */
 var ROOT_PATH = '../../../../../';
 
 // Polymer BrowserTest fixture.
@@ skipping 394 matching lines @@
         });
       });
     });
 
     test('manage input methods', function() {
       var inputMethodsCollapse = languagesPage.$.inputMethodsCollapse;
       var inputMethodSettingsExist = !!inputMethodsCollapse;
       if (cr.isChromeOS) {
         assertTrue(inputMethodSettingsExist);
         var manageInputMethodsButton =
             inputMethodsCollapse.querySelector('.list-button:last-of-type');

[dpapad, 2017/02/07 00:47:16]

This reference to last-of-type as well as the one at line 119 are incorrectly
assuming that it works with CSS classes, which does not seem to be accurate. Can
you add a TODO, or just fix them in the same CL?

[Dan Beam, 2017/02/07 03:08:43]

scottchen@: it is customary to respond to reviewer CLs before landing,
especially those that explicitly ask for this.

if you and dpapad@ talked and decided on something out-of-band, that's fine, but
mention it in this CL so it doesn't look like you've flat-out ignored his
requests as your reviewer.

i could see how a reviewer would not lg your cl without all nits addressed if
stuff like this ^ happens often.

[scottchen, 2017/02/08 00:43:19]

Sorry, missed this comment before landing. Will be addressed in new CL:
https://codereview.chromium.org/2682893002

         MockInteractions.tap(manageInputMethodsButton);
         assertTrue(!!languagesPage.$$('settings-manage-input-methods-page'));
       } else {
         assertFalse(inputMethodSettingsExist);
       }
     });
 
     test('spellcheck', function() {
       var spellCheckCollapse = languagesPage.$.spellCheckCollapse;
       var spellCheckSettingsExist = !!spellCheckCollapse;
@@ skipping 14 matching lines @@
         assertFalse(triggerRow.classList.contains('two-line'));
         assertEquals(
             0, triggerRow.querySelector('.secondary').textContent.length);
 
         languagesPage.set(
             'languages.enabled.0.language.supportsSpellcheck', true);
         languagesPage.set('languages.enabled.0.spellCheckEnabled', true);
         assertTrue(triggerRow.classList.contains('two-line'));
         assertLT(
             0, triggerRow.querySelector('.secondary').textContent.length);
-
-        MockInteractions.tap(
-            spellCheckCollapse.querySelector('.list-button:last-of-type'));
-        assertTrue(!!languagesPage.$$('settings-edit-dictionary-page'));
       }
     });
+
+    if (!cr.isMac) {
+      test('spellcheck edit dictionary page add word button', function() {

[dpapad, 2017/02/07 00:47:16]

Nit (optional): s/add word button/add word validation/

[scottchen, 2017/02/08 00:43:19]

Addressed in new CL: https://codereview.chromium.org/2682893002

+        assertFalse(!!languagesPage.$$('settings-edit-dictionary-page'));
+        var spellCheckCollapse = languagesPage.$.spellCheckCollapse;
+        MockInteractions.tap(
+            spellCheckCollapse.querySelector('.list-button'));
+        var editDictPage = languagesPage.$$('settings-edit-dictionary-page');
+        assertTrue(!!editDictPage);
+        var addWordButton = editDictPage.root.querySelector('paper-button');
+        editDictPage.$.newWord.value = '';
+        assertTrue(!!addWordButton);
+        assertTrue(addWordButton.disabled);
+        editDictPage.$.newWord.value = 'valid word';
+        assertFalse(addWordButton.disabled);
+      });
+    }
   }.bind(this));
 
   // TODO(michaelpg): Test more aspects of the languages UI.
 
   // Run all registered tests.
   mocha.run();
 });