chrome/browser/android/banners/app_banner_manager_android.h - Issue 2670963002: Android: Fire the appinstalled event on WebAPK installation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/banners/app_banner_manager_android.h

Issue 2670963002: Android: Fire the appinstalled event on WebAPK installation. (Closed)

Patch Set: Rebase. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/banners/app_banner_manager_android.h

diff --git a/chrome/browser/android/banners/app_banner_manager_android.h b/chrome/browser/android/banners/app_banner_manager_android.h

index d784833aa35b522bc2c8c10ee45d6cbeef05fd43..daf2d9f626a4c3553792b4cb56a24f175dbf2877 100644

--- a/chrome/browser/android/banners/app_banner_manager_android.h

+++ b/chrome/browser/android/banners/app_banner_manager_android.h

@@ -71,6 +71,8 @@ class AppBannerManagerAndroid

// Registers native methods.

static bool Register(JNIEnv* env);

+ using AppBannerManager::GetWeakPtr;

dominickn 2017/04/24 00:56:30 Instead of using, just make the GetWeakPtr method

Matt Giuca 2017/04/24 01:42:13 Done.

protected:

// Return the ideal badge icon size.

int GetIdealBadgeIconSizeInPx();