Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 // Copyright 2015 The Chromium Authors. All rights reserved. | 1 // Copyright 2015 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_ | 5 #ifndef CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_ |
| 6 #define CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_ | 6 #define CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_ |
| 7 | 7 |
| 8 #include <string> | 8 #include <string> |
| 9 | 9 |
| 10 #include "base/android/scoped_java_ref.h" | 10 #include "base/android/scoped_java_ref.h" |
| (...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 64 const base::android::JavaParamRef<jstring>& japp_title, | 64 const base::android::JavaParamRef<jstring>& japp_title, |
| 65 const base::android::JavaParamRef<jstring>& japp_package, | 65 const base::android::JavaParamRef<jstring>& japp_package, |
| 66 const base::android::JavaParamRef<jstring>& jicon_url); | 66 const base::android::JavaParamRef<jstring>& jicon_url); |
| 67 | 67 |
| 68 // AppBannerManager overrides. | 68 // AppBannerManager overrides. |
| 69 void RequestAppBanner(const GURL& validated_url, bool is_debug_mode) override; | 69 void RequestAppBanner(const GURL& validated_url, bool is_debug_mode) override; |
| 70 | 70 |
| 71 // Registers native methods. | 71 // Registers native methods. |
| 72 static bool Register(JNIEnv* env); | 72 static bool Register(JNIEnv* env); |
| 73 | 73 |
| 74 using AppBannerManager::GetWeakPtr; | |
|
dominickn
2017/04/24 00:56:30
Instead of using, just make the GetWeakPtr method
Matt Giuca
2017/04/24 01:42:13
Done.
| |
| 75 | |
| 74 protected: | 76 protected: |
| 75 // Return the ideal badge icon size. | 77 // Return the ideal badge icon size. |
| 76 int GetIdealBadgeIconSizeInPx(); | 78 int GetIdealBadgeIconSizeInPx(); |
| 77 | 79 |
| 78 // AppBannerManager overrides. | 80 // AppBannerManager overrides. |
| 79 std::string GetAppIdentifier() override; | 81 std::string GetAppIdentifier() override; |
| 80 std::string GetBannerType() override; | 82 std::string GetBannerType() override; |
| 81 int GetIdealPrimaryIconSizeInPx() override; | 83 int GetIdealPrimaryIconSizeInPx() override; |
| 82 int GetMinimumPrimaryIconSizeInPx() override; | 84 int GetMinimumPrimaryIconSizeInPx() override; |
| 83 bool IsWebAppInstalled(content::BrowserContext* browser_context, | 85 bool IsWebAppInstalled(content::BrowserContext* browser_context, |
| (...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 130 | 132 |
| 131 // Whether WebAPKs can be installed. | 133 // Whether WebAPKs can be installed. |
| 132 bool can_install_webapk_; | 134 bool can_install_webapk_; |
| 133 | 135 |
| 134 DISALLOW_COPY_AND_ASSIGN(AppBannerManagerAndroid); | 136 DISALLOW_COPY_AND_ASSIGN(AppBannerManagerAndroid); |
| 135 }; | 137 }; |
| 136 | 138 |
| 137 } // namespace banners | 139 } // namespace banners |
| 138 | 140 |
| 139 #endif // CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_ | 141 #endif // CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_MANAGER_ANDROID_H_ |
| OLD | NEW |