Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: chrome/browser/banners/app_banner_manager.h

Issue 2670963002: Android: Fire the appinstalled event on WebAPK installation. (Closed)
Patch Set: Respond to review. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.h
diff --git a/chrome/browser/banners/app_banner_manager.h b/chrome/browser/banners/app_banner_manager.h
index 487592fd18a86ea796ffaa7e2f0069dbf5e9f8d9..bc7292d3f3bf881852a48ad06271f52c5db7d64c 100644
--- a/chrome/browser/banners/app_banner_manager.h
+++ b/chrome/browser/banners/app_banner_manager.h
@@ -79,6 +79,10 @@ class AppBannerManager : public content::WebContentsObserver,
// nothing if |request_id| does not match the current request.
void SendBannerDismissed(int request_id);
+ // Returns a WeakPtr to this object. Exposed so subclasses/infobars may
+ // may bind callbacks without needing their own WeakPtrFactory.
+ base::WeakPtr<AppBannerManager> GetWeakPtr();
+
// Overridden and passed through base::Bind on desktop platforms. Called when
// the bookmark app install initiated by a banner has completed. Not used on
// Android.
@@ -136,10 +140,6 @@ class AppBannerManager : public content::WebContentsObserver,
virtual int GetIdealPrimaryIconSizeInPx();
virtual int GetMinimumPrimaryIconSizeInPx();
- // Returns a WeakPtr to this object. Exposed so subclasses/infobars may
- // may bind callbacks without needing their own WeakPtrFactory.
- base::WeakPtr<AppBannerManager> GetWeakPtr();
-
// Returns true if |is_debug_mode_| is true or the
// kBypassAppBannerEngagementChecks flag is set.
virtual bool IsDebugMode() const;
« no previous file with comments | « chrome/browser/android/webapps/add_to_homescreen_manager.cc ('k') | chrome/browser/banners/app_banner_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698