Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2670963002: Android: Fire the appinstalled event on WebAPK installation. (Closed)
Patch Set: Respond to review. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/banners/app_banner_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 3c2bf84b619a054868f44941e3bc120bbe56585d..30de668d8ebbe9018ae3fd7e3965c9574a65caaf 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -140,6 +140,10 @@ void AppBannerManager::SendBannerDismissed(int request_id) {
event_->BannerDismissed();
}
+base::WeakPtr<AppBannerManager> AppBannerManager::GetWeakPtr() {
+ return weak_factory_.GetWeakPtr();
+}
+
AppBannerManager::AppBannerManager(content::WebContents* web_contents)
: content::WebContentsObserver(web_contents),
SiteEngagementObserver(SiteEngagementService::Get(
@@ -189,10 +193,6 @@ int AppBannerManager::GetMinimumPrimaryIconSizeInPx() {
return InstallableManager::GetMinimumIconSizeInPx();
}
-base::WeakPtr<AppBannerManager> AppBannerManager::GetWeakPtr() {
- return weak_factory_.GetWeakPtr();
-}
-
bool AppBannerManager::IsDebugMode() const {
return is_debug_mode_ ||
base::CommandLine::ForCurrentProcess()->HasSwitch(
« no previous file with comments | « chrome/browser/banners/app_banner_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698