Android: Fire the appinstalled event on WebAPK installation.

chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

Index: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
index 090e1f260a452ca9e831cda9ca0cc8cafcef5086..3342d5be3b033bd483bed7342a26b23f5c970193 100644
--- a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
+++ b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
@@ -367,13 +367,15 @@ bool AppBannerInfoBarDelegateAndroid::TriggeredFromBanner() const {
 }
 
 void AppBannerInfoBarDelegateAndroid::SendBannerAccepted() {
-  if (weak_manager_ && TriggeredFromBanner()) {
+  if (!weak_manager_)
+    return;
+
+  if (TriggeredFromBanner())
     weak_manager_->SendBannerAccepted(event_request_id_);
-    // TODO(mgiuca): Send the appinstalled event for WebAPKs (but just removing
-    // this check won't be sufficient).
-    if (!is_webapk_)
-      weak_manager_->OnInstall();
-  }
+
+  // Send the appinstalled event in all cases (whether triggered from a banner
+  // or not).
+  weak_manager_->OnInstall();

[dominickn, 2017/02/03 05:54:46]

This doesn't work because weak_manager_ is nullptr for WebAPKs which are
installed from the add to homescreen menu item (see
https://cs.chromium.org/chromium/src/chrome/browser/android/webapps/add_to_ho...)

A super hacky way to fix this is to grab the AppBannerManagerAndroid off the
WebContents when creating this delegate in the A2HS code path. I have not
thought through the implications of that yet, but it feels a bit ugly.

Longer term, the WebAPK stuff is going to get split out of this class.

[Matt Giuca, 2017/04/07 06:41:34]

Done.

 }
 
 void AppBannerInfoBarDelegateAndroid::OnWebApkInstallFinished(