Android: Fire the appinstalled event on WebAPK installation.

chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/guid.h"
 #include "base/location.h"
@@ skipping 349 matching lines @@
   // Prevent the infobar from disappearing, because the infobar will show
   // "Adding" during the installation process.
   return false;
 }
 
 bool AppBannerInfoBarDelegateAndroid::TriggeredFromBanner() const {
   return !is_webapk_ || webapk_install_source_ == webapk::INSTALL_SOURCE_BANNER;
 }
 
 void AppBannerInfoBarDelegateAndroid::SendBannerAccepted() {
-  if (weak_manager_ && TriggeredFromBanner()) {
+  if (!weak_manager_)
+    return;
+
+  if (TriggeredFromBanner())
     weak_manager_->SendBannerAccepted(event_request_id_);
-    // TODO(mgiuca): Send the appinstalled event for WebAPKs (but just removing
-    // this check won't be sufficient).
-    if (!is_webapk_)
-      weak_manager_->OnInstall();
-  }
+
+  // Send the appinstalled event in all cases (whether triggered from a banner
+  // or not).
+  weak_manager_->OnInstall();

[dominickn, 2017/02/03 05:54:46]

This doesn't work because weak_manager_ is nullptr for WebAPKs which are
installed from the add to homescreen menu item (see
https://cs.chromium.org/chromium/src/chrome/browser/android/webapps/add_to_ho...)

A super hacky way to fix this is to grab the AppBannerManagerAndroid off the
WebContents when creating this delegate in the A2HS code path. I have not
thought through the implications of that yet, but it feels a bit ugly.

Longer term, the WebAPK stuff is going to get split out of this class.

[Matt Giuca, 2017/04/07 06:41:34]

Done.

 }
 
 void AppBannerInfoBarDelegateAndroid::OnWebApkInstallFinished(
     bool success,
     const std::string& webapk_package_name) {
   JNIEnv* env = base::android::AttachCurrentThread();
   if (!success) {
     DVLOG(1) << "The WebAPK installation failed.";
     Java_AppBannerInfoBarDelegateAndroid_showWebApkInstallFailureToast(env);
     webapk::TrackInstallEvent(webapk::INSTALL_FAILED);
@@ skipping 82 matching lines @@
 
   TrackDismissEvent(DISMISS_EVENT_BANNER_CLICK);
   return true;
 }
 
 bool RegisterAppBannerInfoBarDelegateAndroid(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace banners