Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 26709019: Vector stores Predicate object as OwnPtr instead of raw pointer in XPath. (Closed)

Created:
7 years, 2 months ago by dshwang
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Vector stores Predicate object as OwnPtr instead of raw pointer in XPath. Vector can handle OwnPtr, so we don't have to delete an element in Vector manually. BUG=307055 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -38 lines) Patch
M Source/core/xml/XPathGrammar.y View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/xml/XPathParser.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/xml/XPathParser.cpp View 3 chunks +4 lines, -6 lines 0 comments Download
M Source/core/xml/XPathPath.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/xml/XPathPath.cpp View 1 chunk +2 lines, -5 lines 0 comments Download
M Source/core/xml/XPathStep.h View 3 chunks +22 lines, -5 lines 0 comments Download
M Source/core/xml/XPathStep.cpp View 5 chunks +19 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dshwang
It is follow-up of https://codereview.chromium.org/26763004/ I mentioned Vector has a bug : Vector<OwnPtr<> > copy ...
7 years, 2 months ago (2013-10-17 08:53:36 UTC) #1
abarth-chromium
lgtm Yeah, swap works well here. The odd copy constructor and assignment operator are a ...
7 years, 2 months ago (2013-10-17 18:45:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/26709019/1
7 years, 2 months ago (2013-10-17 18:46:11 UTC) #3
dshwang
On 2013/10/17 18:45:13, abarth wrote: > lgtm > > Yeah, swap works well here. The ...
7 years, 2 months ago (2013-10-17 19:06:15 UTC) #4
commit-bot: I haz the power
7 years, 2 months ago (2013-10-17 22:26:29 UTC) #5
Message was sent while issue was closed.
Change committed as 159908

Powered by Google App Engine
This is Rietveld 408576698