Source/core/xml/XPathParser.h - Issue 26709019: Vector stores Predicate object as OwnPtr instead of raw pointer in XPath.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xml/XPathParser.h

Issue 26709019: Vector stores Predicate object as OwnPtr instead of raw pointer in XPath. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xml/XPathParser.h

diff --git a/Source/core/xml/XPathParser.h b/Source/core/xml/XPathParser.h

index e837c4dcb10cde20500d6116964d38fb61a1676e..86a52e4c149269fb100d499d120502e2af0d4f4a 100644

--- a/Source/core/xml/XPathParser.h

+++ b/Source/core/xml/XPathParser.h

@@ -76,8 +76,8 @@ public:

void registerParseNode(ParseNode*);

void unregisterParseNode(ParseNode*);

- void registerPredicateVector(Vector<Predicate*>*);

- void deletePredicateVector(Vector<Predicate*>*);

+ void registerPredicateVector(Vector<OwnPtr<Predicate> >*);

+ void deletePredicateVector(Vector<OwnPtr<Predicate> >*);

void registerExpressionVector(Vector<OwnPtr<Expression> >*);

void deleteExpressionVector(Vector<OwnPtr<Expression> >*);

@@ -116,7 +116,7 @@ private:

RefPtr<XPathNSResolver> m_resolver;

HashSet<ParseNode*> m_parseNodes;

- HashSet<Vector<Predicate*>*> m_predicateVectors;

+ HashSet<Vector<OwnPtr<Predicate> >*> m_predicateVectors;

HashSet<Vector<OwnPtr<Expression> >*> m_expressionVectors;

HashSet<String*> m_strings;

HashSet<Step::NodeTest*> m_nodeTests;

« no previous file with comments | « Source/core/xml/XPathGrammar.y ('k') | Source/core/xml/XPathParser.cpp » ('j') | no next file with comments »