Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h

Issue 2670843003: Removes unnecessary mock methods in fake identity service (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h
diff --git a/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h b/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h
index c3e52c47f30cdc8989e9edcd12b8ae4452470745..27e30f9c7d491230caeabb4659fe0fa61b419aac 100644
--- a/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h
+++ b/ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.h
@@ -42,21 +42,19 @@ class FakeChromeIdentityService : public ChromeIdentityService {
void ForgetIdentity(ChromeIdentity* identity,
ForgetIdentityCallback callback) override;
- MOCK_METHOD5(GetAccessToken,
- void(ChromeIdentity* identity,
- const std::string& client_id,
- const std::string& client_secret,
- const std::set<std::string>& scopes,
- const ios::AccessTokenCallback& callback));
+ virtual void GetAccessToken(ChromeIdentity* identity,
sdefresne 2017/02/03 09:17:05 This is a method overridden from ChromeIdentitySer
stkhapugin 2017/02/03 10:12:33 Done.
+ const std::string& client_id,
+ const std::string& client_secret,
+ const std::set<std::string>& scopes,
+ const ios::AccessTokenCallback& callback);
- MOCK_METHOD2(GetAvatarForIdentity,
- void(ChromeIdentity* identity, GetAvatarCallback callback));
+ virtual void GetAvatarForIdentity(ChromeIdentity* identity,
sdefresne 2017/02/03 09:17:05 ditto
stkhapugin 2017/02/03 10:12:34 Done.
+ GetAvatarCallback callback);
- MOCK_METHOD1(GetCachedAvatarForIdentity, UIImage*(ChromeIdentity* identity));
+ virtual UIImage* GetCachedAvatarForIdentity(ChromeIdentity* identity);
sdefresne 2017/02/03 09:17:05 ditto
stkhapugin 2017/02/03 10:12:33 Done.
- MOCK_METHOD2(GetHostedDomainForIdentity,
- void(ChromeIdentity* identity,
- GetHostedDomainCallback callback));
+ virtual void GetHostedDomainForIdentity(ChromeIdentity* identity,
sdefresne 2017/02/03 09:17:06 ditto
stkhapugin 2017/02/03 10:12:34 Done.
+ GetHostedDomainCallback callback);
MOCK_METHOD1(GetMDMDeviceStatus,
ios::MDMDeviceStatus(NSDictionary* user_info));
« no previous file with comments | « no previous file | ios/public/provider/chrome/browser/signin/fake_chrome_identity_service.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698